Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find in currently selected directory in the file browser side pane #1

Open
senotrusov opened this issue May 26, 2009 · 7 comments
Open

Comments

@senotrusov
Copy link

It would be nice if "Search in" field will be filled with currently selected directory in the file browser side pane.

Also, context menu for filebrowser directories may have a link to you plugin window, say "Search in this folder".

@oliver
Copy link
Owner

oliver commented Jun 2, 2009

It would be nice if "Search in" field will be filled with
currently selected directory in the file browser side pane.

That's tricky, from a user interface point-of-view... Currently, the dialog will try to use the same directory as in the last search. If it instead uses the currently-selected directory, it might surprise users that browsing in the file pane influences the values in the search dialog.

Some alternative ideas:

  • add a config option which changes this behavior (straight-forward but lame :)
  • use the file browser directory only when opening search dialog for the first time (currently, it falls back to directory of currently-opened file, or to Gedit's working directory); this should be easy to implement
  • add the file browser directory in the list of recent search dirs, maybe separated with a line

Also, context menu for filebrowser directories may have
a link to you plugin window, say "Search in this folder".

That's a good idea, and probably quite easy to implement. It might also make the other issue a bit less important.

But currently I don't have much time for this, and my local working copy is in the middle of some large rewrites; so can't promise any fix soon.

@oliver
Copy link
Owner

oliver commented Apr 5, 2011

In the latest version in Git there is now a "Search files..." item in the File Browser context menu (it is still pretty much experimental, though). This should cover the second part of this issue.

@odigity
Copy link

odigity commented May 22, 2019

In the latest version in Git there is now a "Search files..." item in the File Browser context menu (it is still pretty much experimental, though). This should cover the second part of this issue.

It doesn't seem to work.

When I click on ⋮, then click on "Search files...", it pops up the search dialog box. However, when I right-click on a folder in the File Browser, then click on "Search files...", nothing happens.

PS - Happy one year anniversary, issue #1.

@oliver
Copy link
Owner

oliver commented May 24, 2019

@odigity: Which Gedit version are you using?

I just tried this with Gedit 3.18.1 and 3.28.1, and it worked fine. But new Gedit versions sometimes break plugins.

@odigity
Copy link

odigity commented May 24, 2019

3.32.0 on Pop!_OS 19.04 (aka Ubuntu 19.04)

@oliver
Copy link
Owner

oliver commented May 24, 2019

Well, I don't have Ubuntu 19.04 available right now, so can't test it.

But I'm not really using Gedit any more, so this project is pretty much unmaintained - sorry. Nowadays there's a Find in Files plugin bundled with Gedit though (you might have to install the gedit-plugins package for this).

@odigity
Copy link

odigity commented May 24, 2019

Yeah, I tried it - it was awful. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants