This repository was archived by the owner on Aug 19, 2025. It is now read-only.
forked from 0xPolygon/zkevm-node
-
Notifications
You must be signed in to change notification settings - Fork 234
NubitDA integration on XLayer Node #246
Open
justinriema
wants to merge
16
commits into
okx:niven/nubit
Choose a base branch
from
RiemaLabs:proof
base: niven/nubit
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sieniven
suggested changes
Sep 9, 2024
Collaborator
sieniven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justinriema Please do a merge conflict resolution so that the PR difference to the branch niven/nubit can be reviewed.
Author
Hi @sieniven we have resolved the conflicts, this PR is ready for review. |
|
I don't actually know what to do |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Development on NubitDA integration as X Layer node's offchain data availability provider.
Corresponding logic has been tested in hardhat docker env.
Changes
Added NubitDA as X Layer node's offchain data availability provider.
Added interaction logic with NubitDA viaPost Sequence and GetSequence.
Added corresponding encoding & decoding logic for interaction with NubitDA
Added corresponding UT for new logic