-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for tarballs #78
Comments
Interesting 👀, I'll take a look sometime this week to see if I can implement it |
I've got a preliminary version working live on the site (not yet working on the API), but there seems to be an odd bug that still needs some work, I'll try getting more progress with it during the week |
awesome, thank you 🙏 |
This requires a slightly larger architectural change than initially thought, it might take me a couple more weeks to actually implement this properly |
@TkDodo well...clearly my estimates are waaayyyyy off 😅 . I'm sorry I just haven't had time to dedicate to adding this feature, but in good news there is a workable temporary solution https://github.com/esm-dev/esm.sh/releases/tag/v136, namely using I'm still planning on adding this feature natively within bundlejs when I find some time (which is getting harder and harder to find). |
This works nicely, thank you 🙏 |
Hi 👋 ,
Thanks for working on bundlejs - really love the tool ❤️ .
We use it to show the bundle size in our readme at https://github.com/TanStack/query, which works great.
Lately, we've started to use pkg.pr.new from stackblitz for continuous builds of our PRs. I wanted to see if I can get a quick bundle size report for one of the PRs, but it doesn't work:
This yields the following error:
I assume this is because the file that gets downloaded is a tarball. Here is a reproduction url:
https://bundlejs.com/?q=https%3A%2F%2Fpkg.pr.new%2F%40tanstack%2Freact-query%407988&treeshake=%5B*%5D&config=%7B%22esbuild%22%3A%7B%22external%22%3A%5B%22react%22%2C%22react-dom%22%5D%7D%7D
It would be awesome if these preview builds could be somehow supported. Having this url as a dependency in a package.json works:
thanks for considering this 🙏
The text was updated successfully, but these errors were encountered: