Skip to content
This repository has been archived by the owner on Aug 3, 2022. It is now read-only.

Email reviewers when a review is needed #354

Open
5 tasks
ondrae opened this issue May 27, 2014 · 9 comments
Open
5 tasks

Email reviewers when a review is needed #354

ondrae opened this issue May 27, 2014 · 9 comments
Milestone

Comments

@ondrae
Copy link
Contributor

ondrae commented May 27, 2014

Description

When a new dataset or revision is submitted, each reviewer should get a an email notifying them to go approve or reject that submission.

I don't know the hosting service that the census uses. If it's Heroku, then Mailgun or SendGrid can be set up easily.

Files

routes/census.js in exports.submitPost

Tasks

Example

for admin in admins:
        response = requests.post(
            # Production app14961102.mailgun.org
            # Staging app17090450.mailgun.org
            "https://api.mailgun.net/v2/app14961102.mailgun.org/messages",
            auth=("api", app.config['MAIL_GUN_KEY']),
            data={"from": "Andrew Hyder <[email protected]>",
                  "to": admin.email,
                  "subject": subject,
                  "html": html})
@pwalsh
Copy link
Member

pwalsh commented Sep 18, 2014

@rgrp we more or less decided to de-prioritise email notification for pending reviews today, so I'm moving this to Next Up, but leaving the 3 star priority "just in case".

cc @svanderwaal @morchickit

@Stephen-Gates
Copy link

As a reviewer I would really like to see this functionality implemented so I don't need to check the site each day to see if something needs to be reviewed. I think if someone makes the effort to add a submission then they should expect a quick turn-around of their work. Quick feedback encourages further contribution.

Perhaps we should consider emailing the submitter (if they provided email address) at each stage:

  • your submission has been received
  • your submission has been reviewed (approved/rejected)

or allow them to subscribe to updates on a place, dataset or entry.

@pwalsh pwalsh added enhancement and removed Backend labels Jun 3, 2015
@morchickit
Copy link
Contributor

I think this feature will drop in the global Index since we might not have country reviewer but thematic review.
@Stephen-Gates - can a report be helpful here?

@schlos
Copy link

schlos commented Jun 4, 2015

+1

@Stephen-Gates
Copy link

@morchickit there is no need for a report in my case (i.e. a Regional census) as the volumes are low and I can just view the ChangeLog on the site. What I was trying to avoid was having to go to the ChangeLog each day to see if there was a new submission. A simple e-mail saying, "there's a new submission" is all that's needed to tell editors to go look.

I understand that things are probably different for the Global Index given its size, the number of people involved, and their differing focuses (country vs thematic). A report would probably be good in this case.

@pwalsh pwalsh modified the milestones: Next Up, Current Jul 16, 2015
@pwalsh
Copy link
Member

pwalsh commented Jul 21, 2015

@morchickit I just realised this is a different request to the one we have scheduled in our user stories. What do you think if this?

@ondrae
Copy link
Contributor Author

ondrae commented Jul 21, 2015

Ever since place based reviewers were added, this is even more needed. For the US census, we have one local volunteer reviewer for each city. An email when the rare update is made will help keep cities up to date.

@morchickit
Copy link
Contributor

@pwalsh - we have to figure our a way do differ between issues that are for the local index, global index or both. In this case, it is not going to be relevant for the global index, but will for the local ones.

@pwalsh
Copy link
Member

pwalsh commented Jul 21, 2015

@ondrae ok.

@morchickit ok.

@pwalsh pwalsh modified the milestones: Current, Backlog Jul 29, 2015
@pwalsh pwalsh removed the ok:local label Jan 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants