Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTS was failing -> now fixed -> URL update todo #3

Open
planetf1 opened this issue Feb 23, 2023 · 9 comments
Open

CTS was failing -> now fixed -> URL update todo #3

planetf1 opened this issue Feb 23, 2023 · 9 comments

Comments

@planetf1
Copy link
Member

planetf1 commented Feb 23, 2023

CTS test

  • Egeria '3.15'
  • xtdb 3.15
  • Large openshift cluster

Config:

# SPDX-License-Identifier: CC-BY-4.0
# Copyright Contributors to the ODPi Egeria project.
tut:
serverType: "plugin"
connectorProvider: "org.odpi.egeria.connectors.juxt.xtdb.repositoryconnector.XtdbOMRSRepositoryConnectorProvider"
connectorConfig:
  xtdbConfig:
    xtdb/index-store:
      kv-store:
        xtdb/module: xtdb.lmdb/->kv-store
        db-dir: data/servers/xtdb/lmdb-index
    xtdb/document-store:
      kv-store:
        xtdb/module: xtdb.rocksdb/->kv-store
        db-dir: data/servers/xtdb/rdb-docs
    xtdb/tx-log:
      kv-store:
        xtdb/module: xtdb.rocksdb/->kv-store
        db-dir: data/servers/xtdb/rdb-tx
    xtdb.lucene/lucene-store:
      db-dir: data/servers/xtdb/lucene
downloads:
- filename: egeria-connector-xtdb.jar
  url: "http://repository.sonatype.org/service/local/artifact/maven/redirect?r=central-proxy&g=org.odpi.egeria&a=egeria-connector-xtdb&v=RELEASE&c=jar-with-dependencies"
  #url: "http://oss.sonatype.org/service/local/artifact/maven/redirect?r=snapshots&g=org.odpi.egeria&a=egeria-connector-xtdb&v=3.15-SNAPSHOT&c=jar-with-dependencies"
  ```
  
  Results
  ```
                Metadata sharing MANDATORY_PROFILE    CONFORMANT_FULL_SUPPORT [  67066 /      0 ]
            Reference copies  OPTIONAL_PROFILE             NOT_CONFORMANT [    535 /    116 ]
        Metadata maintenance  OPTIONAL_PROFILE             NOT_CONFORMANT [      0 /    651 ]
               Dynamic types  OPTIONAL_PROFILE             UNKNOWN_STATUS [      0 /      0 ]
               Graph queries  OPTIONAL_PROFILE             NOT_CONFORMANT [      0 /      1 ]
           Historical search  OPTIONAL_PROFILE             UNKNOWN_STATUS [      0 /      0 ]
              Entity proxies  OPTIONAL_PROFILE             NOT_CONFORMANT [      0 /    238 ]
     Soft-delete and restore  OPTIONAL_PROFILE             UNKNOWN_STATUS [      0 /      0 ]
              Undo an update  OPTIONAL_PROFILE             UNKNOWN_STATUS [      0 /      0 ]
         Reidentify instance  OPTIONAL_PROFILE             NOT_CONFORMANT [      0 /    535 ]
             Retype instance  OPTIONAL_PROFILE             NOT_CONFORMANT [      0 /    297 ]
             Rehome instance  OPTIONAL_PROFILE             UNKNOWN_STATUS [      0 /      0 ]
               Entity search  OPTIONAL_PROFILE             NOT_CONFORMANT [      0 /    594 ]
         Relationship search  OPTIONAL_PROFILE             NOT_CONFORMANT [      0 /    238 ]
      Entity advanced search  OPTIONAL_PROFILE             UNKNOWN_STATUS [      0 /      0 ]
Relationship advanced search  OPTIONAL_PROFILE             UNKNOWN_STATUS [      0 /      0 ]
List the versions of each instance  OPTIONAL_PROFILE             UNKNOWN_STATUS [      0 /      0 ]
Store classifications independently of entity  OPTIONAL_PROFILE             UNKNOWN_STATUS [      0 /      0 ]
          External instances  OPTIONAL_PROFILE             UNKNOWN_STATUS [      0 /      0 ]
Restore metadata from a backup  OPTIONAL_PROFILE             UNKNOWN_STATUS [      0 /      0 ]

FAIL [67601/2670]

Also the automated cts at https://github.com/odpi/egeria-test-cts/actions is currently failing (this uses egeria 'main')
See https://github.com/odpi/egeria-test-cts/actions

Specifically the latest test run shows identical results to above https://github.com/odpi/egeria-test-cts/actions/runs/4249004030

cc: @cmgrote @mandy-chessell

@planetf1
Copy link
Member Author

Update

Checking my k8s run, I had specified a parm to use 3.15 . However :

➜  test-xtdb kubectl describe pod cts-platform-6cb5597bbf-w6jkx | grep  Image
    Image:         quay.io/odpi/egeria-configure:3.15
    Image ID:      quay.io/odpi/egeria-configure@sha256:6eb883ad707dc5b57615f774e0b424dd71fe22ad60bcf441de46d7032e4edee0
    Image:          quay.io/odpi/egeria:latest
    Image ID:       quay.io/odpi/egeria@sha256:5903f737134f4c9957b77e85dd22c2fe0a0bcc61ee748918f40b580c46e407ef
➜  test-xtdb

What is happening is that the 'init' container is using 3.15, whilst the 'platform' (the real test) used latest !

So this cts failure is likely specific to main/v4

@planetf1
Copy link
Member Author

Update - egeria 4.0 (main) requires xtdb connector 4.0.
Will update tests to match

@planetf1 planetf1 transferred this issue from odpi/egeria-connector-xtdb Feb 23, 2023
planetf1 added a commit to planetf1/egeria-test-cts that referenced this issue Feb 23, 2023
@planetf1
Copy link
Member Author

planetf1 commented Feb 23, 2023

PR updates xtdb version to 'latest'
Kicked off action - results in ~4 hours https://github.com/odpi/egeria-test-cts/actions/runs/4251753818
Also rerunning on larger k8s cluster.

@planetf1
Copy link
Member Author

The change I made to the cts did not work -- wrong URL, 'latest' isn't available seemingly from the snapshot repo. I'd misinterpreted the docs. I only get latest release.

Raising a Q with sonatype.

The other option is to add more logic to the scripting to determine the latest xtdb version (including development versions) and then set the connector download string to that specific version

@planetf1
Copy link
Member Author

Raised odpi/egeria-connector-xtdb#466

Once fixed, need to return here to verify the correct URL to use, which is probably ttp://oss.sonatype.org/service/local/artifact/maven/redirect\?r\=snapshots\&g\=org.odpi.egeria\&a\=egeria-connector-xtdb\&v\=LATEST\&c\=jar-with-dependencies .

If so need to update etc/cts.yaml with this URL. But will leave until proven, once the xtdb artifact is correctly published

@planetf1
Copy link
Member Author

^cc: @cmgrote

@planetf1
Copy link
Member Author

XTDB is now published

CTS is clean with main/main

However this uses a hardcoded 4.0-SNAPSHOT reference for the connector, which needs to be updated when we branch

Issue opened at Sonatype community to determine a better URL to use -> https://community.sonatype.com/t/retrieving-the-latest-snapshot/10311/2

@planetf1 planetf1 changed the title CTS failing for xtdb (xtdb 3.15, egeria 3.15/main) CTS was failing -> now fixed -> URL update todo Mar 19, 2023
@planetf1
Copy link
Member Author

planetf1 commented May 9, 2023

XTDB connector is now at 4.0 (release)

Will update the connector to use the 'latest' release connector

➜  /tmp wget "http://repository.sonatype.org/service/local/artifact/maven/redirect\?r\=central-proxy\&g\=org.odpi.egeria\&a\=egeria-connector-xtdb\&v\=LATEST\&c\=jar-with-dependencies"

The charts would need modifying to more easily support selection of connector

The easiest way of managing this would be to allow shell expansion of variables in the downloads, or perhaps just allowing a user script to be run.

Note that the connector download currently fails with: HTTP request sent, awaiting response... 401 Unauthorized after the redirect. Following up with sonatype - https://community.sonatype.com/t/issues-or-something-changed-cannot-download-artifact-without-user-pass-prompt/10593 . This affects ALL downloads, not just egeria artifacts & appears to be a regression.

@planetf1 planetf1 self-assigned this May 9, 2023
@planetf1
Copy link
Member Author

See also #7

@planetf1 planetf1 removed their assignment Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant