Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Feedback Manager and Metadata Explorer to support generic view services #70

Open
dwolfson opened this issue Jan 2, 2025 · 0 comments

Comments

@dwolfson
Copy link
Member

dwolfson commented Jan 2, 2025

Need to update these classes to allow users to specify, for example, the view service to apply feedback to. Today, the query parameters in feedback manager are set with:

possible_query_params = query_string(
[
("isPublic", is_public),
("viewServiceUrlMarker", view_service_url_marker),
("accessServiceUrlMarker", access_service_url_marker),
]
)

So we need to remove the accessServiceUrlMarker and if the viewServiceURLMarker is provided, use it to replace the default URL marker (e.g. feedback-manager) with another module name. So viewServiceURL marker is also removed as a query parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant