Skip to content
This repository was archived by the owner on May 5, 2021. It is now read-only.

Commit fbd5364

Browse files
committed
perf: reduce modifier feature (+ seems unnecessary)
1 parent aa75d55 commit fbd5364

File tree

4 files changed

+4
-9
lines changed

4 files changed

+4
-9
lines changed

packages/core/src/Modifier.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,10 @@ import { Constructor } from '../../utils/src/utils';
22
import { VNode } from './VNodes/VNode';
33
import { VersionableObject } from './Memory/VersionableObject';
44

5-
export type ModifierTypeguard<T extends Modifier> = (
6-
modifier: Modifier,
7-
batch: VNode[],
8-
) => modifier is T;
5+
export type ModifierTypeguard<T extends Modifier> = (modifier: Modifier) => modifier is T;
96
export type ModifierPredicate<T = Modifier | boolean> = T extends Modifier
107
? Constructor<T> | ModifierTypeguard<T>
11-
: (modifier: Modifier, batch: VNode[]) => boolean;
8+
: (modifier: Modifier) => boolean;
129

1310
interface ModifierConstructor {
1411
new <T extends Constructor<Modifier>>(...args: ConstructorParameters<T>): this;

packages/plugin-renderer-dom-object/src/DomObjectRenderingEngine.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -376,7 +376,7 @@ export class DomObjectRenderingEngine extends RenderingEngine<DomObject> {
376376
}
377377
}
378378
// Create format.
379-
const modifierRenderer = this.getCompatibleModifierRenderer(modifier, nodes);
379+
const modifierRenderer = this.getCompatibleModifierRenderer(modifier);
380380
const wraps = await modifierRenderer.render(modifier, domObjects, nodes);
381381

382382
// Add origins.

packages/plugin-renderer/src/ModifierRenderer.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ class SuperModifierRenderer<T> {
1818
render(modifier: Modifier, contents: T[], batch: VNode[]): Promise<T[]> {
1919
const nextRenderer = this.renderer.engine.getCompatibleModifierRenderer(
2020
modifier,
21-
batch,
2221
this.renderer,
2322
);
2423
return nextRenderer?.render(modifier, contents, batch);

packages/plugin-renderer/src/RenderingEngine.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,6 @@ export class RenderingEngine<T = {}> {
150150
*/
151151
getCompatibleModifierRenderer(
152152
modifier: Modifier,
153-
nodes: VNode[],
154153
previousRenderer?: ModifierRenderer<T>,
155154
): ModifierRenderer<T> {
156155
let nextRendererIndex = this.modifierRenderers.indexOf(previousRenderer) + 1;
@@ -162,7 +161,7 @@ export class RenderingEngine<T = {}> {
162161
nextRenderer.predicate &&
163162
!(isConstructor(nextRenderer.predicate, Modifier)
164163
? modifier instanceof nextRenderer.predicate
165-
: nextRenderer.predicate(modifier, nodes))
164+
: nextRenderer.predicate(modifier))
166165
);
167166
return nextRenderer;
168167
}

0 commit comments

Comments
 (0)