-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT]: NPM releases failing due to OTP token (2FA) requirements #2829
Comments
I'll have a look today, I think that should be a straightforward fix |
Ah I'm sorry I mixed up OTP with provenance attestation 🤦🏼 it was pre-coffee ☕ So it seems that the |
I don't see a setting for it on npm. I reached out to the npm team for help |
The current token we use is 5 years old, maybe updating it will resolve the problem. But I don't have access to the I can try to use a token of mine for testing, but will wait on what the @octokit maintainers suggest |
I've just regenerated the token for automation and added it to the org. I am re running the job now. |
Re-running the job won't work since the release was already tagged on GitHub. |
if that happens, we can delete the tag and release notes for it manually, then re-run |
Great point. I can't do that at the moment but I'll try to get to it after I get through my meetings unless one of y'all get to it first. |
I don't see a tag for 18.2.0 though? |
ah sorry I misunderstood, the 18.1.0 tag is the one that needs to be deleted, let me try that. |
I'm around in case you need help testing something 👋🏽 |
The release didn't trigger because it's behind the latest commit on the branch. octokit/openapi#484 once merged should get it to trigger. It's having trouble with the update dry-run test not getting triggered |
Hmm failed again
https://github.com/octokit/openapi/actions/runs/13790432706/job/38568599440#step:5:191 I learned that 2FA can be enforced on a package level, but it's not enabled for ![]() There is some information from people who ran into this problem in the past: semantic-release/npm#209 @nickfloyd just making sure, you created a classic token with type:automation, correct? |
Yes.. updated the ![]() |
okay we figured it out, the 2FA setting was enabled for both authorization and publishing. @nickfloyd changed it to just authorization, and the release now worked via https://github.com/octokit/openapi/actions/runs/13917749582/job/38991546989 |
Moving the discussion from octokit/openapi#483 (comment)
The release workflow is failing because the token suddenly needs a one-time passcode (2FA).
https://github.com/octokit/openapi/actions/runs/13790432706/job/38568599440
The text was updated successfully, but these errors were encountered: