Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta.json contains null fields #9

Open
lowyck opened this issue Aug 7, 2018 · 3 comments
Open

meta.json contains null fields #9

lowyck opened this issue Aug 7, 2018 · 3 comments
Labels
wontfix This will not be worked on

Comments

@lowyck
Copy link
Collaborator

lowyck commented Aug 7, 2018

When creating an exercise from an input file with missing metadata fields, the generated meta.json contains fields with value null. It is avoidable by not generating the meta file at all. Currently, an warning is printed. I think it is better to leave it as is, because building will fail anyway without a meta.json, but not with a null value inside a field that is not strictly mandatory (e.g authors).

@yurug
Copy link

yurug commented Aug 7, 2018

Not sure to understand the part "to leave it as is". You mean that the behavior of learn-ocaml should not be changed?

@lowyck
Copy link
Collaborator Author

lowyck commented Aug 8, 2018

I meant keep the current behaviour of autogen, i.e printing a warning, and outputting a json file, even with null values in it.

@yurug
Copy link

yurug commented Aug 8, 2018

I see and I agree.

@lowyck lowyck added the wontfix This will not be worked on label Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants