Add minimalist Cohttp implementation using Picos_stdio

Author: polytypic

README.md

@@ -44,6 +44,7 @@ scheduler agnostic libraries (e.g.
 [`picos.structured`](https://ocaml-multicore.github.io/picos/doc/picos/Picos_structured/index.html),
 [`picos.sync`](https://ocaml-multicore.github.io/picos/doc/picos/Picos_sync/index.html),
 [`picos.stdio`](https://ocaml-multicore.github.io/picos/doc/picos/Picos_stdio/index.html),
+[`picos.stdio.cohttp`](https://ocaml-multicore.github.io/picos/doc/picos/Picos_stdio_cohttp/index.html),
 and
 [`picos.select`](https://ocaml-multicore.github.io/picos/doc/picos/Picos_select/index.html)),
 or auxiliary libraries.

dune-project

@@ -40,6 +40,13 @@
   ;; For picos.lwt
   (lwt
    (>= 5.7.0))
+  ;; For picos.stdio.cohttp
+  (cohttp
+   (>= 6.0.0~beta2))
+  (uri
+   (>= 4.4.0))
+  (fmt
+   (>= 0.9.0))
   ;; Test dependencies
   (multicore-bench
    (and
@@ -99,10 +106,6 @@
   (ocaml
    (>= 4.14.0)))
  (depopts
-  (cohttp
-   (and
-    (>= 5.3.1)
-    :with-test))
   (cohttp-lwt
    (and
     (>= 5.3.0)
@@ -114,8 +117,4 @@
   (conduit-lwt-unix
    (and
     (>= 6.2.2)
-    :with-test))
-  (uri
-   (and
-    (>= 4.4.0)
     :with-test))))

lib/index.mld

@@ -167,6 +167,7 @@ These are examples of libraries implemented in Picos.
   Picos_structured
   Picos_sync
   Picos_stdio
+  Picos_stdio_cohttp
   Picos_select
 }
 

lib/picos_select/picos_select.ml

@@ -1,8 +1,9 @@
 open Picos
 open Picos_sync
 
-let handle_sigchld_bit = 0b01
-let select_thread_running_on_main_domain_bit = 0b10
+let handle_sigchld_bit = 0b001
+let select_thread_running_on_main_domain_bit = 0b010
+let ignore_sigpipe_bit = 0b100
 
 type config = {
   mutable bits : int;
@@ -267,10 +268,12 @@ let select_thread s =
   if s.pipe_out != Unix.stdin then Unix.close s.pipe_out
 
 let[@poll error] [@inline never] try_configure ~intr_sig ~intr_sigs
-    ~handle_sigchld =
+    ~handle_sigchld ~ignore_sigpipe =
   config.intr_sigs == []
   && begin
-       config.bits <- Bool.to_int handle_sigchld;
+       config.bits <-
+         Bool.to_int handle_sigchld
+         lor (ignore_sigpipe_bit land -Bool.to_int ignore_sigpipe);
        config.intr_sig <- intr_sig;
        config.intr_sigs <- intr_sigs;
        true
@@ -296,17 +299,24 @@ let reconfigure_signal_handlers () =
     if config.bits land handle_sigchld_bit <> 0 then begin
       Sys.signal Sys.sigchld (Sys.Signal_handle handle_signal) |> ignore;
       Thread.sigmask SIG_BLOCK [ Sys.sigchld ] |> ignore
+    end;
+    if config.bits land ignore_sigpipe_bit <> 0 then begin
+      Sys.signal Sys.sigpipe Signal_ignore |> ignore
     end
   end
 
-let configure ?(intr_sig = Sys.sigusr2) ?(handle_sigchld = true) () =
+let configure ?(intr_sig = Sys.sigusr2) ?(handle_sigchld = true)
+    ?(ignore_sigpipe = true) () =
   if not (Picos_thread.is_main_thread ()) then
     invalid_arg "must be called from the main thread on the main domain";
   assert (Sys.sigabrt = -1 && Sys.sigxfsz < Sys.sigabrt);
   if intr_sig < Sys.sigxfsz || 0 <= intr_sig || intr_sig = Sys.sigchld then
     invalid_arg "invalid interrupt signal number";
-  if not (try_configure ~intr_sig ~intr_sigs:[ intr_sig ] ~handle_sigchld) then
-    invalid_arg "already configured";
+  if
+    not
+      (try_configure ~intr_sig ~intr_sigs:[ intr_sig ] ~handle_sigchld
+         ~ignore_sigpipe)
+  then invalid_arg "already configured";
 
   reconfigure_signal_handlers ()
 

lib/picos_select/picos_select.mli

@@ -99,7 +99,8 @@ val on_sigchld : unit Event.t
 
 (** {2 Configuration} *)
 
-val configure : ?intr_sig:int -> ?handle_sigchld:bool -> unit -> unit
+val configure :
+  ?intr_sig:int -> ?handle_sigchld:bool -> ?ignore_sigpipe:bool -> unit -> unit
 (** [configure ~intr_sig ~handle_sigchld ()] can, and sometimes must, be called
     by an application to configure the use of signals by this module.
 
@@ -111,6 +112,10 @@ val configure : ?intr_sig:int -> ?handle_sigchld:bool -> unit -> unit
     When explicitly specified as [~handle_sigchld:false], the application should
     arrange to call {!handle_signal} whenever a {!Sys.sigchld} signal occurs.
 
+    The optional [ignore_sigpipe] argument can be used to specify whether
+    {!Sys.sigpipe} will be configured to be ignored or not.  The default is
+    [true].
+
     ⚠️ This module must always be configured before use.  Unless this module has
     been explicitly configured, calling a method of this module from the main
     thread on the main domain will automatically configure this module with

lib/picos_stdio_cohttp/dune

@@ -0,0 +1,10 @@
+(library
+ (name picos_stdio_cohttp)
+ (public_name picos.stdio.cohttp)
+ (libraries
+  (re_export picos.stdio)
+  (re_export cohttp)
+  (re_export uri)
+  fmt
+  picos.finally
+  picos.structured))