Skip to content

Export types expected by the geo mark #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nshiab opened this issue Feb 4, 2025 · 2 comments
Open

Export types expected by the geo mark #2278

nshiab opened this issue Feb 4, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@nshiab
Copy link

nshiab commented Feb 4, 2025

Hi!

Would it be possible to export the type expected by the geo mark?

This would be helpful when working with TypeScript.

From what I understand, we currently need to install d3-geo to access the GeoPermissible type. If this type were exported directly from plot, explicitly installing d3-geo wouldn't be necessary.

Thank you!

@nshiab nshiab added the enhancement New feature or request label Feb 4, 2025
@Fil
Copy link
Contributor

Fil commented Feb 7, 2025

Would we use https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/geojson/index.d.ts rather than the d3 types here? (We might have to add the sphere object, but I can't really make sense of the additional definitions in GeoPermissible.)

@nshiab
Copy link
Author

nshiab commented Feb 7, 2025

This is a great idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants