Skip to content

Commit d514313

Browse files
committed
A channel of explicit symbols does not show in the tip nor has a legend
closes #2237
1 parent ff7d83c commit d514313

File tree

4 files changed

+396
-2
lines changed

4 files changed

+396
-2
lines changed

src/marks/tip.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -347,8 +347,8 @@ function getSourceChannels(channels, scales) {
347347
if ((key === "x" || key === "y") && channels.geometry) continue; // ignore x & y on geo
348348
const source = getSource(channels, key);
349349
if (source) {
350-
// Ignore color channels if the values are all literal colors.
351-
if (source.scale == null && source.defaultScale === "color") continue;
350+
// Ignore color/symbol channels if the values are all literal colors/symbols.
351+
if (source.scale == null && ["color", "symbol"].includes(source.defaultScale)) continue;
352352
sources[key] = source;
353353
}
354354
}

0 commit comments

Comments
 (0)