Skip to content

Support for npm:d3 and npm:htl #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fil opened this issue Jan 16, 2024 · 3 comments
Closed

Support for npm:d3 and npm:htl #550

Fil opened this issue Jan 16, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Fil
Copy link
Contributor

Fil commented Jan 16, 2024

Salvage e651d6e and 72a4193 from the #458 PR: they allow a .ts or .js import to use d3 and htl with no linting or typescript errors. A test case (like an example) will be nice to have; see for example the examples/plot/ folder. Also check what happens with @observablehq/plot.

@Fil Fil added the enhancement New feature or request label Jan 16, 2024
@Fil Fil added this to the General availability milestone Jan 16, 2024
@Fil Fil self-assigned this Jan 16, 2024
@mbostock mbostock changed the title Typescript support for npm:d3 and npm:htl TypeScript support for npm:d3 and npm:htl Jan 16, 2024
@Fil Fil changed the title TypeScript support for npm:d3 and npm:htl Support for npm:d3 and npm:htl Jan 16, 2024
@Fil
Copy link
Contributor Author

Fil commented Jan 22, 2024

I don't know how to make this work; seems like the fix in 72a4193 was specific to dash being a part of client.

@mbostock
Copy link
Member

This is a vague issue description (given that we obviously already support npm:d3 and npm:htl imports and it’s not clear what is specific to these libraries) and I’m now trying to remember what we‘re fixing here…

@mbostock
Copy link
Member

I don’t see anything wrong here so closing as could not reproduce.

Screenshot 2024-01-23 at 9 33 02 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants