pools for mssql postgres and snowflake

Author: Sylvestre Gug

lib/mssql.js

@@ -5,6 +5,7 @@ import {Transform} from "stream";
 
 import {failedCheck, badRequest, notImplemented} from "./errors.js";
 import {validateQueryPayload} from "./validate.js";
+import Pools from "./pools.js";
 
 const TYPES = mssql.TYPES;
 const READ_ONLY = new Set(["SELECT", "USAGE", "CONNECT"]);
@@ -124,8 +125,6 @@ export async function check(req, res, pool) {
   return {ok: true};
 }
 
-export const ConnectionPool = mssql.ConnectionPool;
-
 export default (credentials) => {
   const pool = new mssql.ConnectionPool(credentials);
 
@@ -144,6 +143,14 @@ export default (credentials) => {
   };
 };
 
+export const pools = new Pools((credentials) =>
+  Object.defineProperty(new mssql.ConnectionPool(credentials), "end", {
+    value() {
+      this.close();
+    },
+  })
+);
+
 // See https://github.com/tediousjs/node-mssql/blob/66587d97c9ce21bffba8ca360c72a540f2bc47a6/lib/datatypes.js#L6
 const boolean = ["null", "boolean"],
   integer = ["null", "integer"],

lib/postgres.js

@@ -3,8 +3,25 @@ import pg from "pg";
 import QueryStream from "pg-query-stream";
 import JSONStream from "JSONStream";
 
+import Pools from "./pools.js";
+
 const {Pool} = pg;
 
+export const pools = new Pools(
+  ({host, port, database, user, password, ssl}) =>
+    new pg.Pool({
+      host,
+      port,
+      database,
+      user,
+      password,
+      ssl: ssl === "required" ? {rejectUnauthorized: false} : false,
+      connectionTimeoutMillis: 25e3,
+      statement_timeout: 240e3,
+      max: 30,
+    })
+);
+
 export default (url) => {
   const pool = new Pool({connectionString: url});
 

lib/snowflake.js

@@ -3,19 +3,40 @@ import {URL} from "url";
 import JSONStream from "JSONStream";
 import snowflake from "snowflake-sdk";
 
-export default url => {
+import Pools from "./pools.js";
+
+export const pools = new Pools(
+  ({host, user, password, database, schema, warehouse, role}) =>
+    Object.defineProperty(
+      snowflake.createConnection({
+        account: host,
+        username: user,
+        password,
+        database,
+        schema,
+        warehouse,
+        role,
+      }),
+      "end",
+      {
+        value() {
+          this.destroy();
+        },
+      }
+    )
+);
+
+export default (url) => {
   url = new URL(url);
-  const {host, username, password, pathname, searchParams} = new URL(
-    url
-  );
+  const {host, username, password, pathname, searchParams} = new URL(url);
   const connection = snowflake.createConnection({
     account: host,
     username,
     password,
     database: pathname.slice(1),
     schema: searchParams.get("schema"),
     warehouse: searchParams.get("warehouse"),
-    role: searchParams.get("role")
+    role: searchParams.get("role"),
   });
 
   const connecting = new WeakSet();
@@ -61,8 +82,8 @@ export default url => {
               (schema[column.getName()] = dataTypeSchema(column)), schema
             ),
             {}
-          )
-      }
+          ),
+      },
     };
     res.end(`,"schema":${JSON.stringify(schema)}}`);
   };