basic config

Author: Sylvestre Gug

.eslintrc.js renamed to .eslintrc.cjs

@@ -0,0 +1,47 @@
+name: Test
+on: push
+
+jobs:
+  test:
+    runs-on: ubuntu-20.04
+    defaults:
+      run:
+        working-directory: .
+    env:
+      DOCKER_PACKAGE: ghcr.io/${{ github.repository }}/database-proxy_test
+
+    steps:
+      - uses: actions/checkout@v3
+      - name: Docker login
+        run: echo ${GITHUB_TOKEN} | docker login -u ${GITHUB_ACTOR} --password-stdin ghcr.io
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+
+      - name: Republish
+        id: republish
+        continue-on-error: true
+        if: ${{ needs.Changes.outputs.connector == 'false' }}
+        run: |
+          ../.github/retry docker pull ${DOCKER_PACKAGE}:${{ github.event.before }}
+          docker tag ${DOCKER_PACKAGE}:${{ github.event.before }} ${DOCKER_PACKAGE}:${GITHUB_SHA}
+          ../.github/retry docker push ${DOCKER_PACKAGE}:${GITHUB_SHA}
+
+      - name: Build
+        if: ${{ steps.republish.outcome != 'success' }}
+        run: |
+          touch .env.test
+          docker-compose build
+      - name: Lint
+        if: ${{ steps.republish.outcome != 'success' }}
+        run: docker-compose run lint
+      - name: Test
+        if: ${{ steps.republish.outcome != 'success' }}
+        run: docker-compose run test
+      - name: Container logs
+        if: failure()
+        run: docker-compose logs --no-color --timestamps
+      - name: Publish
+        if: ${{ steps.republish.outcome != 'success' }}
+        run: |
+          docker tag database-proxy_test:latest ${DOCKER_PACKAGE}:${GITHUB_SHA}
+          ../.github/retry docker push ${DOCKER_PACKAGE}:${GITHUB_SHA}

.github/workflows/test.yml

@@ -1,6 +1,10 @@
 version: "3.7"
 
 services:
+  lint:
+    build: .
+    command: eslint .
+
   test:
     build: .
     depends_on:

docker-compose.yml

@@ -36,10 +36,13 @@
     "@babel/preset-env": "^7.19.4",
     "@babel/register": "^7.18.9",
     "chai": "^4.3.6",
+    "eslint": "^8.32.0",
+    "eslint-plugin-prettier": "^4.2.1",
     "mocha": "^10.1.0",
     "mock-req": "^0.2.0",
     "mock-res": "^0.6.0",
     "nodemon": "^1.19.1",
+    "prettier": "^2.8.3",
     "wait-on": "^6.0.1"
   },
   "peerDependencies": {

package.json

@@ -32,7 +32,7 @@ describe("mssql", () => {
 
   describe("when querying", () => {
     it("should stream the results of simple query", () => {
-      return new Promise(async (resolve, reject) => {
+      return new Promise((resolve) => {
         const req = new MockReq({method: "POST", url: "/query-stream"}).end({
           sql: "SELECT TOP 2 CustomerID FROM test.SalesLT.Customer",
           params: [],
@@ -41,7 +41,7 @@ describe("mssql", () => {
         const res = new MockRes(onEnd);
 
         const index = mssql(credentials);
-        await index(req, res);
+        index(req, res);
 
         function onEnd() {
           const [schema, row] = this._getString().split("\n");
@@ -62,17 +62,18 @@ describe("mssql", () => {
       });
     });
     it("should handle parameter graciously", () => {
-      return new Promise(async (resolve, reject) => {
+      return new Promise((resolve) => {
         const testCustomerId = 3;
         const req = new MockReq({method: "POST", url: "/query-stream"}).end({
-          sql: "SELECT TOP 2 CustomerID FROM test.SalesLT.Customer WHERE CustomerID=@1",
+          sql:
+            "SELECT TOP 2 CustomerID FROM test.SalesLT.Customer WHERE CustomerID=@1",
           params: [testCustomerId],
         });
 
         const res = new MockRes(onEnd);
 
         const index = mssql(credentials);
-        await index(req, res);
+        index(req, res);
 
         function onEnd() {
           const [schema, row] = this._getString().split("\n");
@@ -93,17 +94,18 @@ describe("mssql", () => {
       });
     });
     it("should replace cell reference in the SQL query", () => {
-      return new Promise(async (resolve, reject) => {
+      return new Promise((resolve) => {
         const testCustomerId = 5;
         const req = new MockReq({method: "POST", url: "/query-stream"}).end({
-          sql: "SELECT TOP 2 CustomerID FROM test.SalesLT.Customer WHERE CustomerID=@1",
+          sql:
+            "SELECT TOP 2 CustomerID FROM test.SalesLT.Customer WHERE CustomerID=@1",
           params: [testCustomerId],
         });
 
         const res = new MockRes(onEnd);
 
         const index = mssql(credentials);
-        await index(req, res);
+        index(req, res);
 
         function onEnd() {
           const [schema, row] = this._getString().split("\n");
@@ -124,7 +126,7 @@ describe("mssql", () => {
       });
     });
     it("should handle duplicated column names", () => {
-      return new Promise(async (resolve, reject) => {
+      return new Promise((resolve) => {
         const req = new MockReq({method: "POST", url: "/query-stream"}).end({
           sql: "SELECT 1 as _a1, 2 as _a1 FROM test.SalesLT.SalesOrderDetail",
           params: [],
@@ -133,10 +135,10 @@ describe("mssql", () => {
         const res = new MockRes(onEnd);
 
         const index = mssql(credentials);
-        await index(req, res);
+        index(req, res);
 
         function onEnd() {
-          const [schema, row] = this._getString().split("\n");
+          const [, row] = this._getString().split("\n");
 
           expect(row).to.equal(
             JSON.stringify({
@@ -149,16 +151,17 @@ describe("mssql", () => {
       });
     });
     it("should select the last value of any detected duplicated columns", () => {
-      return new Promise(async (resolve, reject) => {
+      return new Promise((resolve) => {
         const req = new MockReq({method: "POST", url: "/query-stream"}).end({
-          sql: "SELECT TOP 1 ModifiedDate, ModifiedDate FROM test.SalesLT.SalesOrderDetail",
+          sql:
+            "SELECT TOP 1 ModifiedDate, ModifiedDate FROM test.SalesLT.SalesOrderDetail",
           params: [],
         });
 
         const res = new MockRes(onEnd);
 
         const index = mssql(credentials);
-        await index(req, res);
+        index(req, res);
 
         function onEnd() {
           const [schema, row] = this._getString().split("\n");