Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: document all fields returned by VolumeMeasureResult #214

Open
bennyz opened this issue May 26, 2022 · 0 comments
Open

api: document all fields returned by VolumeMeasureResult #214

bennyz opened this issue May 26, 2022 · 0 comments
Labels
bug Issue is a bug or fix for a bug good first issue Good issue for a new contributor storage

Comments

@bennyz
Copy link
Member

bennyz commented May 26, 2022

Currently only required is documented, but the rest of the available fields returned by it are:

{
    "required": 1073741824,
    "fully-allocated": 1073741824
    "bitmaps": 0
}

Engine needs bitmaps to measure correctly when copying volumes with bitmaps.
Note that bitmaps may be missing if there a no bitmaps in the qcow2 image
so the value should be optional (defaultvalue: null).

The bitmap field was added in 4.4.x - find the commit that started to report it,
and use the first release delivering this commit in the added property.

fully-allocated is not needed for anything, so better not document it.

@bennyz bennyz added cleanup Code change keeping current behavior storage good first issue Good issue for a new contributor labels May 26, 2022
@nirs nirs added bug Issue is a bug or fix for a bug and removed cleanup Code change keeping current behavior labels May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is a bug or fix for a bug good first issue Good issue for a new contributor storage
Projects
None yet
Development

No branches or pull requests

2 participants