Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary logs in getVolumeInfo #194

Open
nirs opened this issue May 23, 2022 · 0 comments
Open

Unnecessary logs in getVolumeInfo #194

nirs opened this issue May 23, 2022 · 0 comments
Labels
good first issue Good issue for a new contributor logs Enhancement or fixes to logs storage

Comments

@nirs
Copy link
Member

nirs commented May 23, 2022

When getting volume info during merge, we have too many unnecessary logs repeating info in
int he public API.

2022-05-23 12:28:13,472+0300 INFO  (jsonrpc/7) [vdsm.api] START getVolumeInfo(sdUUID='bafd0f16-9aba-4f9f-ba90-46d3b8a29157', spUUID='fa20ea36-c317-49a6-af6d-afaa5b1561df', imgUUID='4b72aba2-0668-463d-b856-7f0f7406b6a2', volUUID='cd981010-ac48-49e1-b28b-c
bde06c085bf') from=::ffff:192.168.122.10,36058, flow_id=5f388eb2-38fd-4ca9-9b97-fc78ce75fe16, task_id=9d6b6d02-7270-4794-8bc0-18f7ed06570d (api:48)

2022-05-23 12:28:13,552+0300 INFO  (jsonrpc/7) [storage.volumemanifest] Info request: sdUUID=bafd0f16-9aba-4f9f-ba90-46d3b8a29157 imgUUID=4b72aba2-0668-463d-b856-7f0f7406b6a2 volUUID = cd981010-ac48-49e1-b28b-cbde06c085bf  (volume:243)

2022-05-23 12:28:13,568+0300 INFO  (jsonrpc/7) [storage.volumemanifest] bafd0f16-9aba-4f9f-ba90-46d3b8a29157/4b72aba2-0668-463d-b856-7f0f7406b6a2/cd981010-ac48-49e1-b28b-cbde06c085bf info is {'uuid': 'cd981010-ac48-49e1-b28b-cbde06c085bf', 'type': 'SPARS
E', 'format': 'COW', 'disktype': 'DATA', 'voltype': 'INTERNAL', 'capacity': '10737418240', 'parent': '00000000-0000-0000-0000-000000000000', 'description': '{"DiskAlias":"f35_Disk1","DiskDescription":""}', 'pool': '', 'domain': 'bafd0f16-9aba-4f9f-ba90-4
6d3b8a29157', 'image': '4b72aba2-0668-463d-b856-7f0f7406b6a2', 'ctime': '1653297576', 'mtime': '0', 'legality': 'LEGAL', 'generation': 0, 'sequence': 1, 'apparentsize': '2684354560', 'truesize': '2684354560', 'status': 'OK', 'lease': {'path': '/dev/bafd0
f16-9aba-4f9f-ba90-46d3b8a29157/leases', 'offset': 112197632, 'owners': [], 'version': None}, 'children': []} (volume:282)

2022-05-23 12:28:13,568+0300 INFO  (jsonrpc/7) [vdsm.api] FINISH getVolumeInfo return={'info': {'uuid': 'cd981010-ac48-49e1-b28b-cbde06c085bf', 'type': 'SPARSE', 'format': 'COW', 'disktype': 'DATA', 'voltype': 'INTERNAL', 'capacity': '10737418240', 'pare
nt': '00000000-0000-0000-0000-000000000000', 'description': '{"DiskAlias":"f35_Disk1","DiskDescription":""}', 'pool': '', 'domain': 'bafd0f16-9aba-4f9f-ba90-46d3b8a29157', 'image': '4b72aba2-0668-463d-b856-7f0f7406b6a2', 'ctime': '1653297576', 'mtime': '
0', 'legality': 'LEGAL', 'generation': 0, 'sequence': 1, 'apparentsize': '2684354560', 'truesize': '2684354560', 'status': 'OK', 'lease': {'path': '/dev/bafd0f16-9aba-4f9f-ba90-46d3b8a29157/leases', 'offset': 112197632, 'owners': [], 'version': None}, 'c
hildren': []}} from=::ffff:192.168.122.10,36058, flow_id=5f388eb2-38fd-4ca9-9b97-fc78ce75fe16, task_id=9d6b6d02-7270-4794-8bc0-18f7ed06570d (api:54)

Fix:

  • Remove logs storage.volumemanifest logs
    • 2022-05-23 12:28:13,552+0300 INFO  (jsonrpc/7) [storage.volumemanifest] Info request: ...
    • 2022-05-23 12:28:13,568+0300 INFO  (jsonrpc/7) [storage.volumemanifest] bafd0f16-9aba-4f9f-ba90-46d3b8a29157/4b72aba2-0668-463d-b856-7f0f7406b6a2/cd981010-ac48-49e1-b28b-cbde06c085bf info is ...
@nirs nirs added storage good first issue Good issue for a new contributor logs Enhancement or fixes to logs labels May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good issue for a new contributor logs Enhancement or fixes to logs storage
Projects
None yet
Development

No branches or pull requests

1 participant