-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lowering default data iterations #60
Comments
Work has started to begin on this "fix". I'll just be testing how many iterations on average we can see on a few computers. ETA is 6/4 for a fix. |
I've tested iterations on default sizes of terminals on KDE neon, Termux for Android, Windows 10 (PowerShell and the default command prompt), and through Bitvise SSH connecting to a Raspberry Pi. I still need to test out macOS but here's what I've sound so far for default iterations:
PowerShell had some crazy high numbers as to what it could fit, so it's an outlier in this experiment. I couldn't test hurricane data as there aren't any hurricanes floating around, but I may be able to down the road. |
Hey sometimes the notes widget data just gets deleted, so the default iterations above is what we're sticking with. I'll still test macOS to see what works. |
Here's a fun issue: For whatever reason there isn't any option for configuring iterations during config load. Will investigate more... |
To complete this issue, we need to add code to separate out how many iterations occur for each data type. Right now multiple data types rely on a single variable. There goes the thought of PyWeather 1.0.0 being ahead of schedule |
MacOS does appear to be a bit on the lower side of the iteration table. 1 iteration for hourly data (but the 2nd one is entirely visible, just not the date). Forecast data is 2 iterations. Tide data is 5-6 iterations, On the bright side it's a solid 2 iterations for historical hourly. But then it's sad because 2.5 iterations for yesterday hourly. I think I'll keep things the same for now. |
No, it didn't
…On Fri, Jun 1, 2018 at 10:20 AM, o355 ***@***.***> wrote:
I think solving the "asking the user for lower iterations" inside of
configupdate.py won't be an issue, as default number of iterations will
already get implemented with new config variables.
Did that make sense
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#60 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AXjru6we2fmSIZ84V3hRA5hrM3bLqKxDks5t4U2ogaJpZM4SADsA>
.
|
Lowering default data iterations in PyWeather for better readability. Before this gets started I will do a very conclusive study about how much data different terminals on different screens can render.
After that I'll decide on an iteration count that works well. Right now, the 5+ iteration method is only good for full-screen terminals.
To-do list:
The text was updated successfully, but these errors were encountered: