Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How much SLAP is too much? #51

Open
uggi121 opened this issue Sep 6, 2019 · 1 comment
Open

How much SLAP is too much? #51

uggi121 opened this issue Sep 6, 2019 · 1 comment

Comments

@uggi121
Copy link

uggi121 commented Sep 6, 2019

How much abstraction is too much? Adding an extra layer of abstraction has its costs and benefits. In most cost-benefit analyses of abstraction, benefits would be a clear winner.

SLAP seems to be a good guideline in general. However, it is highly likely we reach a stage where further abstractions cause more harm than good. That is, after a point, the costs (refactoring and debugging) would outweigh the benefits. What is a good guideline to follow to ensure that we're adding another layer of abstraction that has enough information to be significant? Is there a quantitative measure, like the reduction in the LoC in the original method, to determine the 'impact'?

@damithc
Copy link
Collaborator

damithc commented Sep 9, 2019

Good point. It is usually a judgement call; there is no quantitative formula. Will touch on this at this week's lecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants