Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging earlier commits with deliverables and naming of classes #26

Open
limhawjia opened this issue Aug 29, 2019 · 1 comment
Open

Comments

@limhawjia
Copy link

Hi, I will be posting Prof Damith's response here for those who are facing the same issue.

  1. For some of the deliverables, e.g. A-MoreOOP, we are required to instructed to construct certain classes with specific names to do specific tasks. However, if we have already implemented classes with the same functionality beforehand, do we have to change their names to match those in the instructions?

It's fine. But you can consider renaming the classes to match the instructions unless you have strong reasons to keep the current name. Using the specified names can make the code reviewers' job easier later.

  1. Also, for deliverables that we have already implemented prior to its corresponding week, e.g. A-Packages in my case, can we simply tag a previous commit with the deliverable?

Yes.

@damithc
Copy link
Collaborator

damithc commented Aug 29, 2019

Thanks for sharing this @limhawjia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants