test: Add e2e test for on-success-sink #3067
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaibhav Tiwari <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3067 +/- ##
=======================================
Coverage 79.64% 79.64%
=======================================
Files 289 289
Lines 65028 65028
=======================================
+ Hits 51791 51794 +3
+ Misses 12687 12684 -3
Partials 550 550 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Vaibhav Tiwari <[email protected]>
Signed-off-by: Vaibhav Tiwari <[email protected]>
Signed-off-by: Vaibhav Tiwari <[email protected]>
Signed-off-by: Vaibhav Tiwari <[email protected]>
Signed-off-by: Vaibhav Tiwari <[email protected]>
Signed-off-by: Vaibhav Tiwari <[email protected]>
Signed-off-by: Vaibhav Tiwari <[email protected]>
vaibhavtiwari33
requested review from
vigith,
whynowy and
yhl25
as code owners
vigith
approved these changes
Dec 6, 2025
Member
vigith
left a comment
vigith
left a comment
There was a problem hiding this comment.
Adding logging fixed it? That sounds suspicious, can you run a couple of times to make sure it is not flaky?
Signed-off-by: Vaibhav Tiwari <[email protected]>
Contributor
Author
|
Sry, that was just for figuring out what the issue was. The issue was that the redis sink implementation image that I had pushed to quay.io was private. Removed logging and will let the test run again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
As part of completing testing for the on-success sink feature, we want to add an end-2-end test which creates a pipeline with on-success UD sink and validates the messages being written to it.
This PR aims to add this test and the manifest which the test uses to create the said pipeline as well as perform a basic validation based on the testing blueprint for fallback sink.
Related issues
Closes: #3046
Testing
This is the test
Special notes for reviewers
Blocker
Requires release of the next version of any one of the SDKs to successfully work.
Currently built go-sdk image with on-success sink changes, used in the manifest, fails to come up due to version restriction imposed in numaflow-core:
SDK version 0.10.1 must be upgraded to at least 0.10.2, in order to work with the current numaflow versionTo bypass the blocker, we've switched to using the redis sink implementation in Rust with the release of v0.4.0 of the Rust SDK