test: Implement redis sink in Rust for on-success sink e2e test #157
+184
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vaibhav Tiwari <[email protected]>
Signed-off-by: Vaibhav Tiwari <[email protected]>
Signed-off-by: Vaibhav Tiwari <[email protected]>
Signed-off-by: Vaibhav Tiwari <[email protected]>
vaibhavtiwari33
changed the title
vaibhavtiwari33
changed the title
vigith
reviewed
Dec 6, 2025
Member
vigith
left a comment
vigith
left a comment
There was a problem hiding this comment.
This is not a simple redis sink, can you please document why it is implemented like this? This will help users when they browse the example and think why is this implemented in a different way :)
examples/redis-sink/src/main.rs
Outdated
| struct RedisTestSink { | ||
| hash_key: String, | ||
| message_count: usize, | ||
| inflight_messages: Arc<Mutex<Vec<SinkRequest>>>, |
Contributor
Author
There was a problem hiding this comment.
I'll be honest I just gave cursor the golang implementation, and it spit this out.
Let me modify this to a proper implementation
Signed-off-by: Vaibhav Tiwari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is based upon the existing go-lang implementation.
In on-success sink implementation, a check was added to ensure min SDK version supporting on-success sink. For Rust SDK, this is v0.4.0
With the release of v0.4.0 for Rust SDK, we can now create a UD sink which can be utilized for on-success sink e2e test