From 81c746f2e9971bdcb18a875952bfcff97e185cb2 Mon Sep 17 00:00:00 2001 From: Vigith Maurice Date: Thu, 26 Sep 2024 19:04:37 -0700 Subject: [PATCH] fix: remove unwanted go routines (#156) Signed-off-by: Vigith Maurice --- pkg/sourcer/service.go | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/pkg/sourcer/service.go b/pkg/sourcer/service.go index d3f0fe7c..90cb63d2 100644 --- a/pkg/sourcer/service.go +++ b/pkg/sourcer/service.go @@ -9,7 +9,6 @@ import ( "runtime/debug" "time" - "golang.org/x/sync/errgroup" "google.golang.org/protobuf/types/known/emptypb" "google.golang.org/protobuf/types/known/timestamppb" @@ -167,14 +166,9 @@ func (fs *Service) AckFn(stream sourcepb.Source_AckFnServer) error { } for { - g, ctx := errgroup.WithContext(ctx) + err := fs.receiveAckRequests(ctx, stream) - g.Go(func() error { - return fs.receiveAckRequests(ctx, stream) - }) - - // Wait for the goroutines to finish - if err := g.Wait(); err != nil { + if err != nil { if errors.Is(err, io.EOF) { return nil }