From 7009262d20f2aae8bebe8aeea6e778ac6c034c2c Mon Sep 17 00:00:00 2001 From: Abdullah Yildirim Date: Mon, 25 Mar 2024 16:02:23 -0400 Subject: [PATCH] chore: add sessionreducer sum example to CI (#114) Signed-off-by: a3hadi --- .github/workflows/build-push.yaml | 9 ++++++--- development.md | 7 ++++++- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-push.yaml b/.github/workflows/build-push.yaml index 82828a32..5e018bbe 100644 --- a/.github/workflows/build-push.yaml +++ b/.github/workflows/build-push.yaml @@ -8,6 +8,9 @@ on: jobs: docker_publish: + # run it only on numaproj/numaflow-go repository + # forked repositories normally don't have the proper permission setup. + if: ${{ github.repository }} == "numaproj/numaflow-go" name: Build, Tag, and Push Image runs-on: ubuntu-latest @@ -17,9 +20,9 @@ jobs: "pkg/mapper/examples/even_odd", "pkg/mapper/examples/flatmap", "pkg/mapper/examples/forward_message", "pkg/mapper/examples/retry", "pkg/mapper/examples/tickgen", "pkg/mapstreamer/examples/flatmap_stream", "pkg/reducer/examples/counter", "pkg/reducer/examples/sum", "pkg/reducestreamer/examples/counter", - "pkg/reducestreamer/examples/sum", "pkg/sessionreducer/examples/counter", "pkg/sideinput/examples/simple-sideinput/udf", - "pkg/sideinput/examples/simple-sideinput", "pkg/sinker/examples/log", "pkg/sourcer/examples/simple_source", - "pkg/sourcetransformer/examples/assign_event_time", "pkg/sourcetransformer/examples/event_time_filter" + "pkg/reducestreamer/examples/sum", "pkg/sessionreducer/examples/counter", "pkg/sessionreducer/examples/sum", + "pkg/sideinput/examples/simple-sideinput/udf", "pkg/sideinput/examples/simple-sideinput", "pkg/sinker/examples/log", + "pkg/sourcer/examples/simple_source", "pkg/sourcetransformer/examples/assign_event_time", "pkg/sourcetransformer/examples/event_time_filter" ] steps: diff --git a/development.md b/development.md index 505305c4..6971f586 100644 --- a/development.md +++ b/development.md @@ -44,4 +44,9 @@ files to reflect this new version: ``` After running the above, create a PR for the changes that the script made. Once merged, it will trigger the Docker Publish workflow. As a result, the correct SDK version will always be printed in the server information logs, -and the example images will always be using the latest changes (due to the local references). \ No newline at end of file +and the example images will always be using the latest changes (due to the local references). + +### Adding a New Example + +If you add a new example, in order for it to be used by the Docker Publish workflow, add its path +to the `dockerfile_paths` matrix in `build-push.yaml`. \ No newline at end of file