From 48847a6622354b7719140597ec119affb4561344 Mon Sep 17 00:00:00 2001 From: a3hadi Date: Mon, 11 Mar 2024 10:24:47 -0400 Subject: [PATCH] modify workflow Signed-off-by: a3hadi --- .github/workflows/build-push.yaml | 13 +++++++------ development.md | 2 +- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/workflows/build-push.yaml b/.github/workflows/build-push.yaml index b5a1726a..2a1904c3 100644 --- a/.github/workflows/build-push.yaml +++ b/.github/workflows/build-push.yaml @@ -1,9 +1,10 @@ name: Docker Publish on: - pull_request -# types: -# - closed + push: + branches: [ main ] + tags: + - '*' jobs: if_merged: @@ -16,9 +17,9 @@ jobs: repository: [ "map-even-odd" "map-flatmap", "map-forward-message", "map-retry", "map-tickgen" -# "map-flatmap-stream", "reduce-counter", "reduce-sum", "reduce-stream-counter", -# "reduce-stream-sum", "session-counter", "sideinput-example", "udf-sideinput-example", -# "sink-log", "source-simple-source", "mapt-assign-event-time", "mapt-event-time-filter" + "map-flatmap-stream", "reduce-counter", "reduce-sum", "reduce-stream-counter", + "reduce-stream-sum", "session-counter", "sideinput-example", "udf-sideinput-example", + "sink-log", "source-simple-source", "mapt-assign-event-time", "mapt-event-time-filter" ] steps: diff --git a/development.md b/development.md index 3bb89c2e..a8cae1ab 100644 --- a/development.md +++ b/development.md @@ -12,7 +12,7 @@ Simply make your changes, build and push the desired example image, and you are ### Deploying 1. Create a PR for your changes. Once merged, it will trigger a workflow to build and push the images for all the examples, -with the tag `stable`. This consistent tag name is used so that the tags in the E2E test pipelines do not need to be +with the tag `stable`. This consistent tag name is used so that the tags in the [E2E test pipelines](https://github.com/numaproj/numaflow/tree/main/test) do not need to be updated each time a new change is made. 2. After the changes have been merged it is encouraged to update the dependency management files so that the version displayed in the `go.mod` file reflects the commit SHA of the merged changes. This can be done simply by getting the