corr: correction for dot_product complex

Author: jvdp1

src/stdlib_experimental_stats_corr.fypp

@@ -243,7 +243,7 @@ contains
               #:endif
                 mask_)
 
-              res(j, i) = dot_product( centerj_, centeri_)&
+              res(j, i) = dot_product( centeri_, centerj_)&
                /sqrt(dot_product( centeri_, centeri_)*&
                      dot_product( centerj_, centerj_))
             end do
@@ -295,7 +295,7 @@ contains
              centerj_ = merge( x(j, :) - mean(x(j, :), mask = mask_),&
                 0._dp, mask_)
 
-             res(j, i) = dot_product( centerj_, centeri_)&
+             res(j, i) = dot_product( centeri_, centerj_)&
                  /sqrt(dot_product( centeri_, centeri_)*&
                        dot_product( centerj_, centerj_))
             end do

src/tests/stats/test_corr.f90

@@ -92,6 +92,15 @@ subroutine test_sp(x, x2)
             ) < sptol)&
             , 'sp check 12')
 
+
+        call check( all(abs(corr(x2, 1, mask = x2 < 1000) - corr(x2, 1))&
+            < sptol)&
+            , 'sp check 13')
+
+        call check( all(abs(corr(x2, 2, mask = x2 < 1000) - corr(x2, 2))&
+            < sptol)&
+            , 'sp check 14')
+
     end subroutine test_sp
 
     subroutine test_dp(x, x2)
@@ -145,6 +154,14 @@ subroutine test_dp(x, x2)
             ) < dptol)&
             , 'dp check 12')
 
+        call check( all(abs(corr(x2, 1, mask = x2 < 1000) - corr(x2, 1))&
+            < dptol)&
+            , 'dp check 13')
+
+        call check( all(abs(corr(x2, 2, mask = x2 < 1000) - corr(x2, 2))&
+            < dptol)&
+            , 'dp check 14')
+
     end subroutine test_dp
 
     subroutine test_int32(x, x2)
@@ -198,6 +215,14 @@ subroutine test_int32(x, x2)
             ) < dptol)&
             , 'int32 check 12')
 
+        call check( all(abs(corr(x2, 1, mask = x2 < 1000) - corr(x2, 1))&
+            < dptol)&
+            , 'int32 check 13')
+
+        call check( all(abs(corr(x2, 2, mask = x2 < 1000) - corr(x2, 2))&
+            < dptol)&
+            , 'int32 check 14')
+
     end subroutine test_int32
 
     subroutine test_int64(x, x2)
@@ -251,6 +276,14 @@ subroutine test_int64(x, x2)
             ) < dptol)&
             , 'int64 check 12')
 
+        call check( all(abs(corr(x2, 1, mask = x2 < 1000) - corr(x2, 1))&
+            < dptol)&
+            , 'int64 check 13')
+
+        call check( all(abs(corr(x2, 2, mask = x2 < 1000) - corr(x2, 2))&
+            < dptol)&
+            , 'int64 check 14')
+
     end subroutine test_int64
 
     subroutine test_csp(x, x2)
@@ -286,12 +319,20 @@ subroutine test_csp(x, x2)
             , 'csp check 7')
 
         call check( all( abs( corr(x2, 2, mask = aimag(x2) < 6) - reshape([&
-             (1._sp,0._sp), (0._sp,-1._sp)&
-             ,(0._sp,1._sp), (1._sp,0._sp)]&
+             (1._sp,0._sp), (0._sp,1._sp)&
+             ,(0._sp,-1._sp), (1._sp,0._sp)]&
             ,[ size(x2, 1), size(x2, 1)])&
             ) < sptol)&
             , 'csp check 8')
 
+        call check( all(abs(corr(x2, 1, mask = aimag(x2) < 1000) - corr(x2, 1))&
+            < sptol)&
+            , 'csp check 9')
+
+        call check( all(abs(corr(x2, 2, mask = aimag(x2) < 1000) - corr(x2, 2))&
+            < sptol)&
+            , 'csp check 10')
+
     end subroutine test_csp
 
     subroutine test_cdp(x, x2)
@@ -327,12 +368,20 @@ subroutine test_cdp(x, x2)
             , 'cdp check 7')
 
         call check( all( abs( corr(x2, 2, mask = aimag(x2) < 6) - reshape([&
-             (1._dp,0._dp), (0._dp,-1._dp)&
-             ,(0._dp,1._dp), (1._dp,0._dp)]&
+             (1._dp,0._dp), (0._dp,1._dp)&
+             ,(0._dp,-1._dp), (1._dp,0._dp)]&
             ,[ size(x2, 1), size(x2, 1)])&
             ) < dptol)&
             , 'cdp check 8')
 
+        call check( all(abs(corr(x2, 1, mask = aimag(x2) < 1000) - corr(x2, 1))&
+            < sptol)&
+            , 'csp check 9')
+
+        call check( all(abs(corr(x2, 2, mask = aimag(x2) < 1000) - corr(x2, 2))&
+            < sptol)&
+            , 'csp check 10')
+
     end subroutine test_cdp
 
 end program test_corr