Support the new package binary file format (coming in Go 1.7)

[kostya-sh]

Probably nothing to do for this issue until Go 1.6 is out but I thought I would file the issue as a reminder anyway.

A new binary export format is coming with Go 1.6 (disabled by default). See the following commit for more details: golang/go@ae2f54a

As I've been experimenting using Go built from tip I've noticed that gocode panics when the new export format is used.

[nsf]

Thanks for letting me know. In my opinion they should just gzip the old format, gives similar ratios.

[kostya-sh]

FYI, golang/go@7538b1d has landed.

gocode no longer works with go tip unless GO_GCFLAGS="-newexport=0" is set.

[nsf]

Will take a look at it this weekend.

[OneOfOne]

A workaround for editors that uses autobuild (vscode in my case):

1. make sure the editor passes -gcflags=-newexport=0 to go install.
2. apply the following patch to gocode and run go install github.com/nsf/gocode

diff --git a/declcache.go b/declcache.go
index 6040d24..d040958 100644
--- a/declcache.go
+++ b/declcache.go
@@ -237,7 +237,7 @@ func build_package(p *build.Package) error {
        }
    }

-   cmd := exec.Command("go", "install", p.ImportPath)
+   cmd := exec.Command("go", "install", "-gcflags=-newexport=0", p.ImportPath)
    cmd.Env = env

    // TODO: Should read STDERR rather than STDOUT.

[nsf]

Or don't use Go master version? What's the rush? Use Go 1.6.

P.S. Already working on binary format parser.

[OneOfOne]

Working on a CL for go1.7, so... but that's great to hear.

[pierrre]

Thank you!

[danp]

With go tip and gocode including de6353c should I still be seeing a panic?

panic: unexpected object tag 58
1(runtime.call32): /Users/dan.peterson/Projects/go/project/go/src/runtime/asm_amd64.s:479
2(runtime.gopanic): /Users/dan.peterson/Projects/go/project/go/src/runtime/panic.go:458
3(main.(*gc_bin_parser).obj): /Users/dan.peterson/Projects/go/src/github.com/nsf/gocode/package_bin.go:204
4(main.(*gc_bin_parser).parse_export): /Users/dan.peterson/Projects/go/src/github.com/nsf/gocode/package_bin.go:114
5(main.(*package_file_cache).process_package_data): /Users/dan.peterson/Projects/go/src/github.com/nsf/gocode/package.go:140
6(main.(*package_file_cache).update_cache): /Users/dan.peterson/Projects/go/src/github.com/nsf/gocode/package.go:89
7(main.update_packages.func1): /Users/dan.peterson/Projects/go/src/github.com/nsf/gocode/autocompletecontext.go:374
8(runtime.goexit): /Users/dan.peterson/Projects/go/project/go/src/runtime/asm_amd64.s:2058

panic: One of the package cache updaters panicked
1(runtime.call32): /Users/dan.peterson/Projects/go/project/go/src/runtime/asm_amd64.s:479
2(runtime.gopanic): /Users/dan.peterson/Projects/go/project/go/src/runtime/panic.go:458
3(main.update_packages): /Users/dan.peterson/Projects/go/src/github.com/nsf/gocode/autocompletecontext.go:382
4(main.(*auto_complete_context).update_caches): /Users/dan.peterson/Projects/go/src/github.com/nsf/gocode/autocompletecontext.go:166
5(main.(*auto_complete_context).apropos): /Users/dan.peterson/Projects/go/src/github.com/nsf/gocode/autocompletecontext.go:303
6(main.server_auto_complete): /Users/dan.peterson/Projects/go/src/github.com/nsf/gocode/server.go:179
7(main.(*RPC).RPC_auto_complete): /Users/dan.peterson/Projects/go/src/github.com/nsf/gocode/rpc.go:26
8(runtime.call64): /Users/dan.peterson/Projects/go/project/go/src/runtime/asm_amd64.s:480
9(reflect.Value.call): /Users/dan.peterson/Projects/go/project/go/src/reflect/value.go:434
10(reflect.Value.Call): /Users/dan.peterson/Projects/go/project/go/src/reflect/value.go:302
11(net/rpc.(*service).call): /Users/dan.peterson/Projects/go/project/go/src/net/rpc/server.go:383
12(runtime.goexit): /Users/dan.peterson/Projects/go/project/go/src/runtime/asm_amd64.s:2058

[danp]

Tried nuking $GOPATH/pkg as well, didn't help.