fix: tweak setGitCommittish

It does more than set one attribute, and shouldn't need to return res if it' mutating in place

Author: wraithgar

lib/npa.js

@@ -183,10 +183,11 @@ Result.prototype.toJSON = function () {
   return result
 }
 
-function setGitCommittish (res, committish) {
+// sets res.gitCommittish, res.gitRange, and res.gitSubdir
+function setGitAttrs (res, committish) {
   if (!committish) {
     res.gitCommittish = null
-    return res
+    return
   }
 
   // for each :: separated item:
@@ -224,8 +225,6 @@ function setGitCommittish (res, committish) {
     }
     log.warn('npm-package-arg', `ignoring unknown key "${name}"`)
   }
-
-  return res
 }
 
 function fromFile (res, where) {
@@ -303,7 +302,8 @@ function fromHostedGit (res, hosted) {
   res.hosted = hosted
   res.saveSpec = hosted.toString({ noGitPlus: false, noCommittish: false })
   res.fetchSpec = hosted.getDefaultRepresentation() === 'shortcut' ? null : hosted.toString()
-  return setGitCommittish(res, hosted.committish)
+  setGitAttrs(res, hosted.committish)
+  return res
 }
 
 function unsupportedURLType (protocol, spec) {
@@ -326,7 +326,7 @@ function fromURL (res) {
     const matched = rawSpec.match(/^git\+ssh:\/\/([^:#]+:[^#]+(?:\.git)?)(?:#(.*))?$/i)
     if (matched && !matched[1].match(/:[0-9]+\/?.*$/i)) {
       res.type = 'git'
-      setGitCommittish(res, matched[2])
+      setGitAttrs(res, matched[2])
       res.fetchSpec = matched[1]
       return res
     }
@@ -345,7 +345,7 @@ function fromURL (res) {
     case 'git+file:':
     case 'git+ssh:':
       res.type = 'git'
-      setGitCommittish(res, parsedUrl.hash.slice(1))
+      setGitAttrs(res, parsedUrl.hash.slice(1))
       if (parsedUrl.protocol === 'git+file:' && /^git\+file:\/\/[a-z]:/i.test(rawSpec)) {
         // URL can't handle drive letters on windows file paths, the host can't contain a :
         res.fetchSpec = `git+file://${parsedUrl.host.toLowerCase()}:${parsedUrl.pathname}`