remove false positive

kartva · kartva · commit a5cbee4d11ff · 2022-09-10T21:04:25.000+05:30
diff --git a/crates/ide-assists/src/handlers/move_format_string_arg.rs b/crates/ide-assists/src/handlers/move_format_string_arg.rs
@@ -51,6 +51,9 @@ pub(crate) fn move_format_string_arg(acc: &mut Assists, ctx: &AssistContext<'_>)
     }
 
     let (new_fmt, extracted_args) = parse_format_exprs(fmt_string.text()).ok()?;
+    if extracted_args.is_empty() {
+        return None;
+    }
 
     acc.add(
         AssistId("move_format_string_arg", AssistKind::QuickFix),

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,9 @@ pub(crate) fn move_format_string_arg(acc: &mut Assists, ctx: &AssistContext<'_>)`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`let (new_fmt, extracted_args) = parse_format_exprs(fmt_string.text()).ok()?;`
	`54`	`+ if extracted_args.is_empty() {`
	`55`	`+ return None;`
	`56`	`+ }`
`54`	`57`
`55`	`58`	`acc.add(`
`56`	`59`	`AssistId("move_format_string_arg", AssistKind::QuickFix),`