Fixes fossasia#5205 feat: Load local image default_system_image.png for default system image (fossasia#5312)

bhaveshAn · Kreijstal · commit fb9f056ac552 · 2018-08-13T18:57:01.000+07:00
diff --git a/app/api/event_topics.py b/app/api/event_topics.py
@@ -1,9 +1,12 @@
 from flask_rest_jsonapi import ResourceDetail, ResourceList, ResourceRelationship
+import urllib.error
 
 from app.api.bootstrap import api
 from app.api.helpers.db import safe_query
+from app.api.helpers.exceptions import UnprocessableEntity
 from app.api.schema.event_topics import EventTopicSchema
 from app.models import db
+from app.api.helpers.files import create_system_image
 from app.models.event import Event
 from app.models.event_sub_topic import EventSubTopic
 from app.models.event_topic import EventTopic
@@ -14,10 +17,41 @@ class EventTopicList(ResourceList):
     """
     List and create event topics
     """
+    def after_create_object(self, event_topic, data, view_kwargs):
+        """
+        after create method to save roles for users and add the user as an accepted role(organizer)
+        :param event_topic:
+        :param data:
+        :param view_kwargs:
+        :return:
+        """
+        if data.get('system_image_url'):
+            try:
+                uploaded_image = create_system_image(data['system_image_url'], unique_identifier=event_topic.id)
+            except (urllib.error.HTTPError, urllib.error.URLError):
+                raise UnprocessableEntity(
+                    {'source': 'attributes/system-image-url'}, 'Invalid Image URL'
+                )
+            except IOError:
+                raise UnprocessableEntity(
+                    {'source': 'attributes/system-image-url'}, 'Image is absent at URL'
+                )
+        else:
+            try:
+                uploaded_image = create_system_image(unique_identifier=event_topic.id)
+            except IOError:
+                raise UnprocessableEntity(
+                    {'source': ''}, 'Default Image is absent in server'
+                )
+
+        self.session.query(EventTopic).filter_by(id=event_topic.id).update(uploaded_image)
+        self.session.commit()
+
     decorators = (api.has_permission('is_admin', methods="POST"),)
     schema = EventTopicSchema
     data_layer = {'session': db.session,
-                  'model': EventTopic}
+                  'model': EventTopic,
+                  'methods': {'after_create_object': after_create_object}}
 
 
 class EventTopicDetail(ResourceDetail):
@@ -49,11 +83,41 @@ def before_get_object(self, view_kwargs):
             else:
                 view_kwargs['id'] = None
 
+    def before_update_object(self, event_topic, data, view_kwargs):
+        """
+        method to save image urls before updating event object
+        :param event_topic:
+        :param data:
+        :param view_kwargs:
+        :return:
+        """
+        if data.get('system_image_url'):
+            try:
+                uploaded_image = create_system_image(data['system_image_url'], unique_identifier=event_topic.id)
+            except (urllib.error.HTTPError, urllib.error.URLError):
+                raise UnprocessableEntity(
+                    {'source': 'attributes/system-image-url'}, 'Invalid Image URL'
+                )
+            except IOError:
+                raise UnprocessableEntity(
+                    {'source': 'attributes/system-image-url'}, 'Image is absent at URL'
+                )
+        else:
+            try:
+                uploaded_image = create_system_image(unique_identifier=event_topic.id)
+            except IOError:
+                raise UnprocessableEntity(
+                    {'source': ''}, 'Default Image is absent in server'
+                )
+
+            data['system_image_url'] = uploaded_image['system_image_url']
+
     decorators = (api.has_permission('is_admin', methods="PATCH,DELETE"),)
     schema = EventTopicSchema
     data_layer = {'session': db.session,
                   'model': EventTopic,
                   'methods': {
+                      'before_update_object': before_update_object,
                       'before_get_object': before_get_object
                   }}
 
diff --git a/app/api/helpers/files.py b/app/api/helpers/files.py
@@ -196,6 +196,56 @@ def create_save_image_sizes(image_file, image_sizes_type, unique_identifier=None
     return new_images
 
 
+def create_system_image(image_file=None, upload_path=None, unique_identifier=None,
+                        ext='jpg'):
+    """
+    Create System Images for Event Topics
+    :param upload_path:
+    :param ext:
+    :param remove_after_upload:
+    :param image_file:
+    :return:
+    """
+    # Get an unique identifier from uuid if not provided
+    filename = '{filename}.{ext}'.format(filename=get_file_name(), ext=ext)
+    if image_file:
+        with urllib.request.urlopen(image_file) as img_data:
+            image_file = io.BytesIO(img_data.read())
+    else:
+        file_relative_path = 'static/default_system_image.png'
+        image_file = app.config['BASE_DIR'] + '/' + file_relative_path
+    try:
+        im = Image.open(image_file)
+    except IOError:
+        raise IOError("Corrupt/Invalid Image")
+
+    # Convert to jpeg for lower file size.
+    if im.format is not 'JPEG':
+        img = im.convert('RGB')
+    else:
+        img = im
+
+    temp_file_relative_path = 'static/media/temp/' + generate_hash(str(image_file)) + get_file_name() + '.jpg'
+    temp_file_path = app.config['BASE_DIR'] + '/' + temp_file_relative_path
+    dir_path = temp_file_path.rsplit('/', 1)[0]
+
+    # create dirs if not present
+    if not os.path.isdir(dir_path):
+        os.makedirs(dir_path)
+
+    img.save(temp_file_path)
+    upfile = UploadedFile(file_path=temp_file_path, filename=filename)
+
+    if not upload_path:
+        upload_path = UPLOAD_PATHS['event_topic']['system_image'].format(event_topic_id=unique_identifier)
+
+    uploaded_url = upload(upfile, upload_path)
+    os.remove(temp_file_path)
+
+    image = {'system_image_url': uploaded_url}
+    return image
+
+
 def make_frontend_url(path, parameters=None):
     """
     Create URL for frontend
diff --git a/app/api/helpers/storage.py b/app/api/helpers/storage.py
@@ -75,6 +75,9 @@
         'large': 'custom-placeholders/{identifier}/large',
         'icon': 'custom-placeholders/{identifier}/icon'
     },
+    'event_topic': {
+        'system_image': 'event_topic/{event_topic_id}/system_image'
+    },
     'pdf': {
         'ticket_attendee': 'attendees/tickets/pdf/{identifier}'
     }
diff --git a/app/api/schema/event_topics.py b/app/api/schema/event_topics.py
@@ -21,7 +21,7 @@ class Meta:
 
     id = fields.Str(dump_only=True)
     name = fields.Str(required=True)
-    system_image_url = fields.Url(dump_only=True)
+    system_image_url = fields.Url()
     slug = fields.Str(dump_only=True)
     events = Relationship(attribute='event',
                           many=True,
diff --git a/app/factories/event_topic.py b/app/factories/event_topic.py
@@ -11,3 +11,4 @@ class Meta:
 
     name = common.string_
     slug = common.slug_
+    system_image_url = common.imageUrl_
diff --git a/docs/api/api_blueprint.apib b/docs/api/api_blueprint.apib
@@ -1818,6 +1818,7 @@ Event Topics for Events. Can only be edited and entered by admins.
 |:----------|-------------|------|----------|
 | `name`  | Name of the event topic | string | - |
 | `slug` | Slug of the event topic | string | - |
+| `system-image-url` | Url of system image of event topic | string | - |
 
 
 ## Event Topics Collection [/v1/event-topics{?page%5bsize%5d,page%5bnumber%5d,sort}]
@@ -1861,7 +1862,8 @@ Get a list of Event Topics.
               },
               "attributes": {
                 "name": "Travel & Outdoor",
-                "slug": "travel-outdoor"
+                "slug": "travel-outdoor",
+                "system-image-url": "https://www.w3schools.com/html/pic_mountain.jpg"
               },
               "type": "event-topic",
               "id": "1",
@@ -1893,7 +1895,8 @@ Create a new event topic with name.
             {
               "data": {
                 "attributes": {
-                  "name": "Travel & Outdoor"
+                  "name": "Travel & Outdoor",
+                  "system-image-url": "https://www.w3schools.com/html/pic_mountain.jpg"
                 },
                 "type": "event-topic"
               }
@@ -1919,7 +1922,8 @@ Create a new event topic with name.
               },
               "attributes": {
                 "name": "Travel & Outdoor",
-                "slug": "travel-outdoor"
+                "slug": "travel-outdoor",
+                "system-image-url": "https://www.w3schools.com/html/pic_mountain.jpg"
               },
               "type": "event-topic",
               "id": "1",
@@ -1970,7 +1974,8 @@ Get a single event topic.
             },
             "attributes": {
               "name": "Travel & Outdoor",
-              "slug": "travel-outdoor"
+              "slug": "travel-outdoor",
+              "system-image-url": "https://www.w3schools.com/html/pic_mountain.jpg"
             },
             "type": "event-topic",
             "id": "1",
@@ -2005,7 +2010,8 @@ Authorized user must be admin.
             {
               "data": {
                 "attributes": {
-                  "name": "Travel & Outdoor"
+                  "name": "Travel & Outdoor",
+                  "system-image-url": "https://www.w3schools.com/html/pic_mountain.jpg"
                 },
                 "type": "event-topic",
                 "id": "1"
@@ -2032,7 +2038,8 @@ Authorized user must be admin.
             },
             "attributes": {
               "name": "Travel & Outdoor",
-              "slug": "travel-outdoor"
+              "slug": "travel-outdoor",
+              "system-image-url": "https://www.w3schools.com/html/pic_mountain.jpg"
             },
             "type": "event-type",
             "id": "1",
@@ -2106,7 +2113,8 @@ Delete a single event topic.
                 },
                 "attributes": {
                     "slug": "travel-outdoor",
-                    "name": "Travel & Outdoor"
+                    "name": "Travel & Outdoor",
+                    "system-image-url": "https://www.w3schools.com/html/pic_mountain.jpg"
                 },
                 "type": "event-topic",
                 "id": "1",
@@ -2158,7 +2166,8 @@ Delete a single event topic.
                 },
                 "attributes": {
                     "slug": "travel-outdoor",
-                    "name": "Travel & Outdoor"
+                    "name": "Travel & Outdoor",
+                    "system-image-url": "https://www.w3schools.com/html/pic_mountain.jpg"
                 },
                 "type": "event-topic",
                 "id": "1",
diff --git a/static/.gitignore b/static/.gitignore
@@ -1,4 +1,4 @@
 *
 */
 !.gitignore
-!header.png
+!default_system_image.png
diff --git a/static/default_system_image.png b/static/default_system_image.png

Original file line number	Diff line number	Diff line change
`@@ -11,3 +11,4 @@ class Meta:`
`11`	`11`
`12`	`12`	`name = common.string_`
`13`	`13`	`slug = common.slug_`
	`14`	`+ system_image_url = common.imageUrl_`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`	`1`	`*`
`2`	`2`	`*/`
`3`	`3`	`!.gitignore`
`4`		`-!header.png`
	`4`	`+!default_system_image.png`