Skip to content

Commit 51e043b

Browse files
committed
chore(ci): fixed the typecheck missing issue, switched to node-version matrix
Signed-off-by: Neko Ayaka <[email protected]>
1 parent bd58242 commit 51e043b

File tree

1 file changed

+10
-52
lines changed

1 file changed

+10
-52
lines changed

.github/workflows/ci.yaml

+10-52
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,19 @@ jobs:
1515
lint:
1616
strategy:
1717
matrix:
18-
os: [ubuntu-latest, windows-latest]
18+
node-version: ['18.x', '20.x']
1919

20-
name: Lint - ${{ matrix.os }}
21-
runs-on: ${{ matrix.os }}
20+
name: Lint - ${{ matrix.node-version }}
21+
runs-on: 'ubuntu-latest'
2222

2323
steps:
2424
- name: Checkout
2525
uses: actions/checkout@v3
2626

27-
- name: Install Node.js 20.x
27+
- name: Install Node.js ${{ matrix.node-version }}
2828
uses: actions/setup-node@v3
2929
with:
30-
node-version: 20.x
30+
node-version: ${{ matrix.node-version }}
3131

3232
- name: Install pnpm
3333
uses: pnpm/action-setup@v2
@@ -54,64 +54,22 @@ jobs:
5454
- name: Lint
5555
run: pnpm run lint
5656

57-
typecheck:
58-
strategy:
59-
matrix:
60-
os: [ubuntu-latest, windows-latest]
61-
62-
name: Typecheck - ${{ matrix.os }}
63-
runs-on: ${{ matrix.os }}
64-
65-
steps:
66-
- name: Checkout
67-
uses: actions/checkout@v3
68-
69-
- name: Install Node.js 20.x
70-
uses: actions/setup-node@v3
71-
with:
72-
node-version: 20.x
73-
74-
- name: Install pnpm
75-
uses: pnpm/action-setup@v2
76-
with:
77-
run_install: false
78-
version: 8
79-
80-
- name: Obtain pnpm store directory
81-
shell: bash
82-
run: |
83-
echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV
84-
85-
- name: Obtain pnpm store cache
86-
uses: actions/cache@v3
87-
with:
88-
path: ${{ env.STORE_PATH }}
89-
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
90-
restore-keys: |
91-
${{ runner.os }}-pnpm-store-
92-
93-
- name: Install dependencies
94-
run: pnpm install --frozen-lockfile
95-
96-
- name: Typecheck
97-
run: pnpm run typecheck
98-
9957
packages-build-test:
10058
strategy:
10159
matrix:
102-
os: [ubuntu-latest, windows-latest]
60+
node-version: ['18.x', '20.x']
10361

104-
name: Packages Build Test - ${{ matrix.os }}
105-
runs-on: ${{ matrix.os }}
62+
name: Packages Build Test - ${{ matrix.node-version }}
63+
runs-on: 'ubuntu-latest'
10664

10765
steps:
10866
- name: Checkout
10967
uses: actions/checkout@v3
11068

111-
- name: Install Node.js 20.x
69+
- name: Install Node.js ${{ matrix.node-version }}
11270
uses: actions/setup-node@v3
11371
with:
114-
node-version: 20.x
72+
node-version: ${{ matrix.node-version }}
11573

11674
- name: Install pnpm
11775
uses: pnpm/action-setup@v2

0 commit comments

Comments
 (0)