-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
Run Prettier as part of the blog post script #6041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I feel that this is a mismanagement of expectations: #6040 (comment) As if they simply run @targos have you at least run |
I did run |
You're not expected. Just saying that you can run that command to test/view the blog post locally :)
That's odd, because Husky should be adding a precommit hook to prettify files. @bmuenzenmeyer can you check into that / see if there's a ignore maybe? |
Note that Git Hooks and npm install scripts are disabled globally on my computer for security reasons. |
I think in this case the rendered post wouldn't look different. Prettier only asked to remove unnecessary escapes. |
Youre absolutely right. Sorry my prettier comment was not related to running locally to preview the post. Just wanted to say that previewing a new blog post to verify it looks as expected is nice. But I suppose Vercel branch deployments already do that for you, so disregard that! |
Note that Git Hooks and npm install scripts are disabled globally on my computer for security reasons. Oh, that makes sense. Right, then @bmuenzenmeyer might make sense to invoke prettier/eslint CLI directly from the blog script. And then write the resulting content to the file. |
I'm also fine with a documentation update in https://github.com/nodejs/node/blob/main/doc/contributing/releases.md#17-create-a-blog-post that asks to run whatever is needed. |
Originally posted by @targos in #6040 (comment)
See https://github.com/nodejs/nodejs.org/blob/main/scripts/release-post/index.mjs - add a exec call to run prettier in some way.
You can validate this works by re-running the 21.1.0 release from which this issue came
The text was updated successfully, but these errors were encountered: