build: fix android build

[necm1]

This commit fixes a bug in the V8 engine as detailed in the linked issue.

All tests pass locally.

Fixes: #58505

Info

To build Node.js on a Mac with Apple Silicon (& Android NDK), you need to switch to the Rosetta architecture (x86_64) before starting the build process. If you run into issues related to ‎⁠LLONG_MAX⁠ from ‎⁠limits.h (not included)⁠, the only workaround is to define ‎LLONG_MAX⁠ manually like this:

deps/uv/src/unix/linux.c

#include <limits.h>

#ifndef LLONG_MAX
#define LLONG_MAX 9223372036854775807LL
#endif

Build

Make sure you've installed Android NDK.

1. python3 android-configure $ANDROID_NDK_HOME 24 arm64
2. make -j2

[nodejs-github-bot]

Review requested:

• @nodejs/gyp
• @nodejs/v8-update

[bnoordhuis]

LGTM and I'll take your word for it that it builds. The commit log should be something like build: fix android build with a Fixes: https://github.com/nodejs/node/issues/58505 line.

[targos]

Since both cases are now identical, can we remove the condition and move the sources to the main sources array (starting at line 1445)

[necm1]

LGTM and I'll take your word for it that it builds. The commit log should be something like build: fix android build with a Fixes: https://github.com/nodejs/node/issues/58505 line.

I have updated the commit message and included the build process. Please note that there might still be build errors on Apple Silicon processors.

[AbdullahZughbi]

Still errors...

[avivkeller]

Still errors...

Perhaps detail the errors you received to improve the debugging process

[AbdullahZughbi]

Still errors...

Perhaps detail the errors you received to improve the debugging process

Here's the link: #58505

[AbdullahZughbi]

Android issues has been fixed?

[AbdullahZughbi]

Any user(s) here?
I have modified stack_trace_posix.cc to bypass..

#if (V8_LIBC_GLIBC || V8_LIBC_BSD || V8_LIBC_UCLIBC || V8_OS_SOLARIS) && !defined(__ANDROID__)
#define HAVE_EXECINFO_H 1
#endif

[AbdullahZughbi]

Use /user/bin if build icu, etc...
Use android ndk bin build if node, etc...

[avivkeller]

Can you fix this spacing?

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6946/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70657/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6946/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6946/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70686/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6951/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6951/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6951/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70900/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6970/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6970/

[nodejs-github-bot]

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6970/

[github-actions]

Failed to start CI

- Validating Jenkins credentials
✔  Jenkins credentials valid
- Querying data for job/node-test-pull-request/70900/
[SyntaxError: Unexpected token '<', ..."    
  https://github.com/nodejs/node/actions/runs/26100654712