Skip to content

Commit 88d789a

Browse files
targosRafaelGSS
authored andcommitted
src: use correct way to signal interceptor error
PR-URL: #54418 Refs: https://github.com/nodejs/node/blob/e4f61de14f8cfb83f1ce0ad1597b86278cd5f5f1/deps/v8/include/v8-function-callback.h#L398-L408 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Cheng Zhao <[email protected]>
1 parent fe4a92a commit 88d789a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/node_webstorage.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -572,8 +572,8 @@ static Intercepted StorageSetter(Local<Name> property,
572572
Storage* storage;
573573
ASSIGN_OR_RETURN_UNWRAP(&storage, info.This(), Intercepted::kNo);
574574

575-
if (storage->Store(property, value)) {
576-
info.GetReturnValue().Set(value);
575+
if (!storage->Store(property, value)) {
576+
info.GetReturnValue().SetFalse();
577577
}
578578

579579
return Intercepted::kYes;

0 commit comments

Comments
 (0)