Skip to content

Commit 7380252

Browse files
nodejs-github-botnodejs-github-bot
authored
deps: patch V8 to 12.4.254.17
Refs: v8/v8@12.4.254.14...12.4.254.17 PR-URL: #52980 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
1 parent 37960ff commit 7380252

File tree

5 files changed

+48
-33
lines changed

5 files changed

+48
-33
lines changed

‎deps/v8/include/v8-version.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#define V8_MAJOR_VERSION 12
1212
#define V8_MINOR_VERSION 4
1313
#define V8_BUILD_NUMBER 254
14-
#define V8_PATCH_LEVEL 14
14+
#define V8_PATCH_LEVEL 17
1515

1616
// Use 1 for candidates and 0 otherwise.
1717
// (Boolean macro values are not supported by all preprocessors.)

‎deps/v8/infra/testing/builders.pyl

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -962,7 +962,7 @@
962962
'v8_mac64_asan_rel': {
963963
'swarming_dimensions' : {
964964
'cpu': 'x86-64',
965-
'os': 'Mac-13',
965+
'os': 'Mac-14',
966966
},
967967
'tests': [
968968
{'name': 'v8testing', 'shards': 8},
@@ -971,7 +971,7 @@
971971
'v8_mac64_dbg': {
972972
'swarming_dimensions' : {
973973
'cpu': 'x86-64',
974-
'os': 'Mac-13',
974+
'os': 'Mac-14',
975975
},
976976
'tests': [
977977
{'name': 'mozilla'},
@@ -984,7 +984,7 @@
984984
'v8_mac_arm64_gc_stress_dbg': {
985985
'swarming_dimensions' : {
986986
'cpu': 'arm64',
987-
'os': 'Mac-13',
987+
'os': 'Mac-14',
988988
},
989989
'tests': [
990990
{'name': 'd8testing', 'test_args': ['--gc-stress'], 'shards': 3},
@@ -993,7 +993,7 @@
993993
'v8_mac64_noopt_dbg': {
994994
'swarming_dimensions' : {
995995
'cpu': 'x86-64',
996-
'os': 'Mac-13',
996+
'os': 'Mac-14',
997997
},
998998
'tests': [
999999
{'name': 'v8testing', 'shards': 6},
@@ -1002,7 +1002,7 @@
10021002
'v8_mac64_rel': {
10031003
'swarming_dimensions' : {
10041004
'cpu': 'x86-64',
1005-
'os': 'Mac-13',
1005+
'os': 'Mac-14',
10061006
},
10071007
'tests': [
10081008
{'name': 'mozilla'},
@@ -1015,7 +1015,7 @@
10151015
'v8_mac_arm64_rel': {
10161016
'swarming_dimensions' : {
10171017
'cpu': 'arm64',
1018-
'os': 'Mac-13',
1018+
'os': 'Mac-14',
10191019
'pool': 'chromium.tests',
10201020
},
10211021
'tests': [
@@ -1031,7 +1031,7 @@
10311031
'v8_mac_arm64_dbg': {
10321032
'swarming_dimensions' : {
10331033
'cpu': 'arm64',
1034-
'os': 'Mac-13',
1034+
'os': 'Mac-14',
10351035
'pool': 'chromium.tests',
10361036
},
10371037
'tests': [
@@ -1047,7 +1047,7 @@
10471047
'v8_mac_arm64_full_dbg': {
10481048
'swarming_dimensions' : {
10491049
'cpu': 'arm64',
1050-
'os': 'Mac-13',
1050+
'os': 'Mac-14',
10511051
'pool': 'chromium.tests',
10521052
},
10531053
'tests': [
@@ -1063,7 +1063,7 @@
10631063
'v8_mac_arm64_no_pointer_compression_dbg': {
10641064
'swarming_dimensions' : {
10651065
'cpu': 'arm64',
1066-
'os': 'Mac-13',
1066+
'os': 'Mac-14',
10671067
'pool': 'chromium.tests',
10681068
},
10691069
'tests': [
@@ -1848,7 +1848,7 @@
18481848
'V8 Mac64': {
18491849
'swarming_dimensions': {
18501850
'cpu': 'x86-64',
1851-
'os': 'Mac-13',
1851+
'os': 'Mac-14',
18521852
},
18531853
'tests': [
18541854
{'name': 'mozilla'},
@@ -1861,7 +1861,7 @@
18611861
'V8 Mac64 - debug': {
18621862
'swarming_dimensions': {
18631863
'cpu': 'x86-64',
1864-
'os': 'Mac-13',
1864+
'os': 'Mac-14',
18651865
},
18661866
'tests': [
18671867
{'name': 'mozilla'},
@@ -1874,7 +1874,7 @@
18741874
'V8 Mac64 ASAN': {
18751875
'swarming_dimensions': {
18761876
'cpu': 'x86-64',
1877-
'os': 'Mac-13',
1877+
'os': 'Mac-14',
18781878
},
18791879
'tests': [
18801880
{'name': 'v8testing', 'shards': 10},
@@ -1883,15 +1883,15 @@
18831883
'V8 Mac - arm64 - gc stress': {
18841884
'swarming_dimensions': {
18851885
'cpu': 'arm64',
1886-
'os': 'Mac-13',
1886+
'os': 'Mac-14',
18871887
},
18881888
'tests': [
18891889
{'name': 'd8testing', 'test_args': ['--gc-stress'], 'shards': 3},
18901890
],
18911891
},
18921892
'V8 Mac - arm64': {
18931893
'swarming_dimensions' : {
1894-
'os': 'Mac-13',
1894+
'os': 'Mac-14',
18951895
'cpu': 'arm64',
18961896
'pool': 'chromium.tests',
18971897
},
@@ -1908,7 +1908,7 @@
19081908
},
19091909
'V8 Mac - arm64 - release': {
19101910
'swarming_dimensions' : {
1911-
'os': 'Mac-13',
1911+
'os': 'Mac-14',
19121912
'cpu': 'arm64',
19131913
'pool': 'chromium.tests',
19141914
},
@@ -1925,7 +1925,7 @@
19251925
},
19261926
'V8 Mac - arm64 - debug': {
19271927
'swarming_dimensions' : {
1928-
'os': 'Mac-13',
1928+
'os': 'Mac-14',
19291929
'cpu': 'arm64',
19301930
'pool': 'chromium.tests',
19311931
},
@@ -1943,7 +1943,7 @@
19431943
'V8 Mac - arm64 - no pointer compression debug': {
19441944
'swarming_dimensions' : {
19451945
'cpu': 'arm64',
1946-
'os': 'Mac-13',
1946+
'os': 'Mac-14',
19471947
'pool': 'chromium.tests',
19481948
},
19491949
'tests': [

‎deps/v8/src/compiler/access-info.cc

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -526,6 +526,14 @@ PropertyAccessInfo AccessorAccessInfoHelper(
526526
Cell::cast(module_namespace->module()->exports()->Lookup(
527527
isolate, name.object(),
528528
Smi::ToInt(Object::GetHash(*name.object())))));
529+
if (IsAnyStore(access_mode)) {
530+
// ES#sec-module-namespace-exotic-objects-set-p-v-receiver
531+
// ES#sec-module-namespace-exotic-objects-defineownproperty-p-desc
532+
//
533+
// Storing to a module namespace object is always an error or a no-op in
534+
// JS.
535+
return PropertyAccessInfo::Invalid(zone);
536+
}
529537
if (IsTheHole(cell->value(kRelaxedLoad), isolate)) {
530538
// This module has not been fully initialized yet.
531539
return PropertyAccessInfo::Invalid(zone);

‎deps/v8/src/maglev/maglev-graph-builder.cc

Lines changed: 21 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4001,19 +4001,28 @@ ReduceResult MaglevGraphBuilder::TryBuildPropertyStore(
40014001
access_info.holder().value());
40024002
}
40034003

4004-
if (access_info.IsFastAccessorConstant()) {
4005-
return TryBuildPropertySetterCall(access_info, receiver,
4006-
GetAccumulatorTagged());
4007-
} else {
4008-
DCHECK(access_info.IsDataField() || access_info.IsFastDataConstant());
4009-
ReduceResult res = TryBuildStoreField(access_info, receiver, access_mode);
4010-
if (res.IsDone()) {
4011-
RecordKnownProperty(receiver, name,
4012-
current_interpreter_frame_.accumulator(),
4013-
AccessInfoGuaranteedConst(access_info), access_mode);
4014-
return res;
4004+
switch (access_info.kind()) {
4005+
case compiler::PropertyAccessInfo::kFastAccessorConstant:
4006+
return TryBuildPropertySetterCall(access_info, receiver,
4007+
GetAccumulatorTagged());
4008+
case compiler::PropertyAccessInfo::kDataField:
4009+
case compiler::PropertyAccessInfo::kFastDataConstant: {
4010+
ReduceResult res = TryBuildStoreField(access_info, receiver, access_mode);
4011+
if (res.IsDone()) {
4012+
RecordKnownProperty(
4013+
receiver, name, current_interpreter_frame_.accumulator(),
4014+
AccessInfoGuaranteedConst(access_info), access_mode);
4015+
return res;
4016+
}
4017+
return ReduceResult::Fail();
40154018
}
4016-
return ReduceResult::Fail();
4019+
case compiler::PropertyAccessInfo::kInvalid:
4020+
case compiler::PropertyAccessInfo::kNotFound:
4021+
case compiler::PropertyAccessInfo::kDictionaryProtoDataConstant:
4022+
case compiler::PropertyAccessInfo::kDictionaryProtoAccessorConstant:
4023+
case compiler::PropertyAccessInfo::kModuleExport:
4024+
case compiler::PropertyAccessInfo::kStringLength:
4025+
UNREACHABLE();
40174026
}
40184027
}
40194028

‎deps/v8/src/objects/js-objects.cc

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -432,9 +432,7 @@ Maybe<bool> JSReceiver::SetOrCopyDataProperties(
432432
Nothing<bool>());
433433

434434
if (!from->HasFastProperties() && target->HasFastProperties() &&
435-
!IsJSGlobalProxy(*target)) {
436-
// JSProxy is always in slow-mode.
437-
DCHECK(!IsJSProxy(*target));
435+
IsJSObject(*target) && !IsJSGlobalProxy(*target)) {
438436
// Convert to slow properties if we're guaranteed to overflow the number of
439437
// descriptors.
440438
int source_length;

0 commit comments

Comments
 (0)