Skip to content

Commit 11222b5

Browse files
committed
fix test
1 parent 9fbd211 commit 11222b5

File tree

1 file changed

+13
-42
lines changed

1 file changed

+13
-42
lines changed

test/parallel/test-repl-tab-complete-getter-error.js

Lines changed: 13 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -24,57 +24,28 @@ async function runTest() {
2424
replServer._domain.on('error', (e) => {
2525
assert.fail(`Error in REPL domain: ${e}`);
2626
});
27+
2728
await new Promise((resolve, reject) => {
2829
replServer.eval(`
29-
class Person1 {
30-
constructor(name) { this.name = name; }
31-
get name() { throw new Error(); } set name(value) { this._name = value; }
32-
};
33-
const foo = new Person1("Alice")
34-
`, replServer.context, '', (err) => {
30+
const getNameText = () => "name";
31+
const foo = { get name() { throw new Error(); } };
32+
`, replServer.context, '', (err) => {
3533
if (err) {
3634
reject(err);
3735
} else {
3836
resolve();
3937
}
4038
});
4139
});
42-
replServer.complete(
43-
'foo.name.',
44-
common.mustCall((error, data) => {
45-
assert.strictEqual(error, null);
46-
assert.strictEqual(data.length, 2);
47-
assert.strictEqual(data[1], 'foo.name.');
48-
})
49-
);
5040

51-
replServer.complete(
52-
'foo["name"].',
53-
common.mustCall((error, data) => {
54-
assert.strictEqual(error, null);
55-
assert.strictEqual(data.length, 2);
56-
assert.strictEqual(data[1], 'foo["name"].');
57-
})
58-
);
59-
await new Promise((resolve, reject) => {
60-
replServer.eval(`
61-
function getNameText() {
62-
return "name";
63-
}
64-
`, replServer.context, '', (err) => {
65-
if (err) {
66-
reject(err);
67-
} else {
68-
resolve();
69-
}
70-
});
41+
['foo.name.', 'foo["name"].', 'foo[getNameText()].'].forEach((test) => {
42+
replServer.complete(
43+
test,
44+
common.mustCall((error, data) => {
45+
assert.strictEqual(error, null);
46+
assert.strictEqual(data.length, 2);
47+
assert.strictEqual(data[1], test);
48+
})
49+
);
7150
});
72-
replServer.complete(
73-
'foo[getNameText()].',
74-
common.mustCall((error, data) => {
75-
assert.strictEqual(error, null);
76-
assert.strictEqual(data.length, 2);
77-
assert.strictEqual(data[1], 'foo[getNameText()].');
78-
})
79-
);
8051
}

0 commit comments

Comments
 (0)