Skip to content

Commit 0309619

Browse files
icarter09tniessen
authored andcommitted
test: use reserved invalid hostname for tests
PR-URL: #14781 Refs: https://tools.ietf.org/html/rfc2606#section-2 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
1 parent 4f1eddf commit 0309619

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

test/parallel/test-net-better-error-messages-port-hostname.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@ const net = require('net');
44
const assert = require('assert');
55

66
// Using port 0 as hostname used is already invalid.
7-
const c = net.createConnection(0, '***');
7+
const c = net.createConnection(0, 'this.hostname.is.invalid');
88

99
c.on('connect', common.mustNotCall());
1010

1111
c.on('error', common.mustCall(function(e) {
1212
assert.strictEqual(e.code, 'ENOTFOUND');
1313
assert.strictEqual(e.port, 0);
14-
assert.strictEqual(e.hostname, '***');
14+
assert.strictEqual(e.hostname, 'this.hostname.is.invalid');
1515
}));

test/parallel/test-net-connect-immediate-finish.js

+5-2
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,17 @@ const common = require('../common');
2424
const assert = require('assert');
2525
const net = require('net');
2626

27-
const client = net.connect({ host: '***', port: common.PORT });
27+
const client = net.connect({
28+
host: 'this.hostname.is.invalid',
29+
port: common.PORT
30+
});
2831

2932
client.once('error', common.mustCall((err) => {
3033
assert(err);
3134
assert.strictEqual(err.code, err.errno);
3235
assert.strictEqual(err.code, 'ENOTFOUND');
3336
assert.strictEqual(err.host, err.hostname);
34-
assert.strictEqual(err.host, '***');
37+
assert.strictEqual(err.host, 'this.hostname.is.invalid');
3538
assert.strictEqual(err.syscall, 'getaddrinfo');
3639
}));
3740

0 commit comments

Comments
 (0)