Skip to content

Commit 007a825

Browse files
authored
tls: move _tls_* to end-of-life
1 parent 5de368f commit 007a825

11 files changed

+6
-55
lines changed

β€Ždoc/api/deprecations.mdβ€Ž

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4147,14 +4147,17 @@ npx codemod@latest @nodejs/repl-builtin-modules
41474147

41484148
<!-- YAML
41494149
changes:
4150+
- version: REPLACEME
4151+
pr-url: https://github.com/nodejs/node/pull/60658
4152+
description: End-of-Life.
41504153
- version:
41514154
- v24.2.0
41524155
- v22.17.0
41534156
pr-url: https://github.com/nodejs/node/pull/57643
41544157
description: Runtime deprecation.
41554158
-->
41564159

4157-
Type: Runtime
4160+
Type: End-of-Life
41584161

41594162
The `node:_tls_common` and `node:_tls_wrap` modules are deprecated as they should be considered
41604163
an internal nodejs implementation rather than a public facing API, use `node:tls` instead.

β€Žlib/_tls_common.jsβ€Ž

Lines changed: 0 additions & 10 deletions
This file was deleted.

β€Žlib/_tls_wrap.jsβ€Ž

Lines changed: 0 additions & 11 deletions
This file was deleted.

β€Žlib/eslint.config_partial.mjsβ€Ž

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -511,7 +511,6 @@ export default [
511511
{
512512
files: [
513513
'lib/_http_*.js',
514-
'lib/_tls_*.js',
515514
'lib/http.js',
516515
'lib/http2.js',
517516
'lib/internal/http.js',

β€Žlib/internal/main/mksnapshot.jsβ€Ž

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ const supportedModules = new SafeSet(new SafeArrayIterator([
4848
'_stream_transform',
4949
'_stream_wrap',
5050
'_stream_writable',
51-
// '_tls_common',
52-
// '_tls_wrap',
5351
'assert',
5452
'assert/strict',
5553
// 'async_hooks',

β€Žsrc/node_builtins.ccβ€Ž

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,8 +132,8 @@ BuiltinLoader::BuiltinCategories BuiltinLoader::GetBuiltinCategories() const {
132132
#endif // !NODE_USE_V8_PLATFORM || !defined(NODE_HAVE_I18N_SUPPORT)
133133

134134
#if !HAVE_OPENSSL
135-
"crypto", "crypto/promises", "https", "http2", "tls", "_tls_common",
136-
"_tls_wrap", "internal/tls/parse-cert-string", "internal/tls/common",
135+
"crypto", "crypto/promises", "https", "http2", "tls",
136+
"internal/tls/parse-cert-string", "internal/tls/common",
137137
"internal/tls/wrap", "internal/tls/secure-context",
138138
"internal/http2/core", "internal/http2/compat",
139139
"internal/streams/lazy_transform",

β€Žtest/parallel/test-internal-module-require.jsβ€Ž

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@ const expectedPublicModules = new Set([
3030
'_stream_transform',
3131
'_stream_wrap',
3232
'_stream_writable',
33-
'_tls_common',
34-
'_tls_wrap',
3533
'assert',
3634
'async_hooks',
3735
'buffer',

β€Žtest/parallel/test-process-get-builtin.mjsβ€Ž

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ if (!isMainThread) {
2525
if (!hasCrypto) {
2626
publicBuiltins.delete('crypto');
2727
publicBuiltins.delete('tls');
28-
publicBuiltins.delete('_tls_common');
29-
publicBuiltins.delete('_tls_wrap');
3028
publicBuiltins.delete('http2');
3129
publicBuiltins.delete('https');
3230
publicBuiltins.delete('inspector');

β€Žtest/parallel/test-warn-tls-common-deprecation.jsβ€Ž

Lines changed: 0 additions & 11 deletions
This file was deleted.

β€Žtest/parallel/test-warn-tls-wrap-deprecation.jsβ€Ž

Lines changed: 0 additions & 11 deletions
This file was deleted.

0 commit comments

Comments
Β (0)