Skip to content

Commit af0d7b8

Browse files
Gabriel Schulhofrvagg
Gabriel Schulhof
authored and
rvagg
committed
test: use Nan in duplicate_symbols
Use `Nan::Set()` and `Nan::GetFunction()` instead of their V8 equivalents to avoid OSX test failures with Node.js v12.x. Thanks @rvagg! Re: nodejs/node-addon-api#456 Fixes: nodejs/node#26765 PR-URL: #1689 Reviewed-By: Rod Vagg <[email protected]>
1 parent 2cf1f78 commit af0d7b8

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

‎test/node_modules/duplicate_symbols/binding.cc

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎test/node_modules/duplicate_symbols/package.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)