|
| 1 | +# Node.js Technical Steering Committee (TSC) Meeting 2025-01-22 |
| 2 | + |
| 3 | +## Links |
| 4 | + |
| 5 | +* **Recording**: <https://www.youtube.com/watch?v=EpjcRGnCHII> |
| 6 | +* **GitHub Issue**: <https://github.com/nodejs/TSC/issues/1676> |
| 7 | + |
| 8 | +## Present |
| 9 | + |
| 10 | +* Antoine du Hamel @aduh95 (voting member) |
| 11 | +* Ruben Bridgewater @BridgeAR (voting member) |
| 12 | +* James Snell @jasnell (voting member) |
| 13 | +* Joyee Cheung @joyeecheung (voting member) |
| 14 | +* Chengzhong Wu @legendecas (voting member) |
| 15 | +* Marco Ippolito @marco-ippolito (voting member) |
| 16 | +* Matteo Collina @mcollina (voting member) |
| 17 | +* Michael Dawson @mhdawson (voting member) |
| 18 | +* Richard Lau @richardlau (voting member) |
| 19 | +* Robert Nagy @ronag (voting member) |
| 20 | +* Ruy Adorno @ruyadorno (voting member) |
| 21 | +* Paolo Insogna @ShogunPanda (voting member) |
| 22 | +* Joe Sepi @joesepi (Guest - Node.js CPC rep) |
| 23 | +* Joshua M. Clulow (Guest: illumos/SmartOS platform) |
| 24 | +* Brie (Guest: illumos/SmartOS platform) |
| 25 | + |
| 26 | +## Agenda |
| 27 | + |
| 28 | +### Announcements |
| 29 | + |
| 30 | +* Matteo: Organization for collaborator summit is under way, please submit session if you would like to have one, and if you need travel funding please submit request as well. |
| 31 | +* Richard: Security releases this week, please upgrade accordingly |
| 32 | + |
| 33 | +### Reminders |
| 34 | + |
| 35 | +* Remember to nominate people for the [contributor spotlight](https://github.com/nodejs/node/blob/main/doc/contributing/reconizing-contributors.md#bi-monthly-contributor-spotlight) |
| 36 | + |
| 37 | +### CPC and Board Meeting Updates |
| 38 | + |
| 39 | +*Extracted from **tsc-agenda** labeled issues and pull requests from the **nodejs org** prior to the meeting |
| 40 | + |
| 41 | +* CPC updates |
| 42 | + * Joe: board meeting this week. So if anything to be brought up let Joe or Matteo know |
| 43 | +* Matteo, also mentioned to reach out to him if there is anything to be brought to the board |
| 44 | + |
| 45 | +### nodejs/node |
| 46 | + |
| 47 | +* doc: change smartos support type to experimental [#56220](https://github.com/nodejs/node/pull/56220) |
| 48 | + * Matteo, @anonrig had proposed lowering to experimental, and possibly removing |
| 49 | + from the regular CI runs |
| 50 | + * Marco, some issues for the 20.x staging, have not started CI yet, failing before on SmartOs |
| 51 | + * James, appreciate the increased effort, key issue has been issues blocking progress on |
| 52 | + PRs, which is what Yagiz experienced, have experienced those as well. As we make |
| 53 | + on improving support for the machines would be good to have agreement on what |
| 54 | + we do to move forward. |
| 55 | + * Brie if something has been known to be flaky, then ok with skipping. But if it was known |
| 56 | + to be stable then I would like to have that be investigated. |
| 57 | + * Joshua, tests which are flaky should be marked as flaky |
| 58 | + * Matteo: in the past, what has been done for certain platforms, put in test, skip the test |
| 59 | + * Michael: and platform teams have been, ok based on understanding and can prioritize |
| 60 | + when to fix that. |
| 61 | + * Michael: To James point, as work is done to improve, can we set a time after an |
| 62 | + at mention to the smartOS team, its ok to skip after 5 days. |
| 63 | + * Joshua that would be good for us |
| 64 | + * James sounds good for us as well |
| 65 | + * James every flaky test should have a test. |
| 66 | + * Michael: in terms of releases, will continue to ping team and discuss in the release issue |
| 67 | + * Joshua, was hoping to assign issue to people and label them, but don’t seem to be |
| 68 | + able to do that. |
| 69 | + * general consensus, leave it as it is for now, and see how progress goes in terms |
| 70 | + of improving responsiveness. |
| 71 | + * James will talk to Yagiz to update and ask if he would be ok in removing from agenda for |
| 72 | + now. To be added back if progress is not made |
| 73 | + * Matteo, some work to be done with respect to reliability CI repo. That documents the |
| 74 | + CI failures - <https://github.com/nodejs/reliability/blob/main/reports/2025-01-22.md> |
| 75 | + * reliability report is a good place to look and chase down failures |
| 76 | + * skipping it ok, particularly if platform team is comfortable skipping. |
| 77 | + |
| 78 | +* test: improve zlib tests [#55716](https://github.com/nodejs/node/pull/55716) |
| 79 | + * two topics |
| 80 | + * migrate to use test runner |
| 81 | + * changing test structure |
| 82 | + * discussing both together is making the discussion harder to progress |
| 83 | + * This one in particular is about whether to use test runner as much as possible |
| 84 | + * PR - <https://github.com/nodejs/node/pull/56027> - to set policy |
| 85 | + * Chengzhong, seems like we don’t have consensus in the PR yet |
| 86 | + * James, not going to engage in the conversation, to frustrating, conversation for me is not |
| 87 | + healthy |
| 88 | + * problem is that we have new contributors, they open PRs and get discouraged because |
| 89 | + they are blocked without interesting |
| 90 | + * Joyee, 2 kinds of PRs, one not related to style, others which change to style of their liking, |
| 91 | + those are more debatable, and more risky. |
| 92 | + * Michael, fundamental issue is that we don’t have consensus on moving all tests to test |
| 93 | + running. Agree with Joyee that we should not recommend new collaborators to make |
| 94 | + stylistic changes unless it is agreed/documented that the project wants to move in |
| 95 | + that direction. |
| 96 | + * Joyee, node-test is unrelated, but good to have guidelines in terms of what we should |
| 97 | + add to the tests. Still not convinced stylistic changes are good for backports |
| 98 | + * Marco, from the point of view of a Releaser, migrating tests for the sake of migrations will |
| 99 | + cause a lot of work/headaches, migrating for for the sake of migrating, |
| 100 | + * Ronag, don’t think we are addressing the key issue, more documented should be easier, but |
| 101 | + the rest introduce the change people are concerned about |
| 102 | + * Matteo: personally there is will from 3rd party runtimes to say they are Node.js compatible |
| 103 | + by running the tests. Test suite was not built with that in mind and creating a certification |
| 104 | + program for other runtimes is a lot of effort and that only really matters for those who |
| 105 | + develop other runtimes. Not sure how to solve, except to create separate certification |
| 106 | + Suite. Not convinced the current test suite is the starting point for that. |
| 107 | + * James, work is not necessarily using node-test, but figuring out how to move in that |
| 108 | + direction. |
| 109 | + * Joyee, node-test encourages grouping files, which may not be great for James use case. |
| 110 | + * Michael for the original issue what we need is more specific direction/documentation. For example, |
| 111 | + one option that allows forward progess but not adding too much work for the project would be |
| 112 | + to only accept stylistic changes along with other changes to tests fix problems with the |
| 113 | + test, reduce flakiness etc. That might be too slow to achieve James' goals though. What we really |
| 114 | + need is to agree on direction and document it, so that we avoid people being surprised\ |
| 115 | + when they propose stylistic only changes. |
| 116 | + * Ronald, thinkig about ideas that might work, how about a new set of tests, and project runs both? |
| 117 | + * James, will likely develop other test suite. |
| 118 | + * Joyee, that sounds like what I suggested a while ago. We don’t ask other runtimes |
| 119 | + so that they can run their tests on Node.js |
| 120 | + |
| 121 | +### nodejs/TSC |
| 122 | + |
| 123 | +* Clarify the Charter so that contractors are explicitly counted as affiliated [#1650](https://github.com/nodejs/TSC/pull/1650) |
| 124 | + * CPC approved, Matteo will land after meeting |
| 125 | + |
| 126 | +* doc: add funding goals [#1678](https://github.com/nodejs/TSC/pull/1678) |
| 127 | + * Michael, TSC members please take a look and comment/approve |
| 128 | + |
| 129 | +* Let's talk about the CI situation [#1614](https://github.com/nodejs/TSC/issues/1614) |
| 130 | + * skipped this week as we ran out of time |
| 131 | + |
| 132 | +* Status of smartOS support and what future holds [#1663](https://github.com/nodejs/TSC/issues/1663) |
| 133 | + * Covered in discussion above |
| 134 | + |
| 135 | +## Strategic Initiatives |
| 136 | +* skipped this week as we ran out of time. |
| 137 | + |
| 138 | +## Upcoming Meetings |
| 139 | + |
| 140 | +* **Node.js Project Calendar**: <https://nodejs.org/calendar> |
| 141 | + |
| 142 | +Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. |
0 commit comments