Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow uploading empty files (allowEmptyFiles option) #475

Closed
tunnckoCore opened this issue Jun 24, 2018 · 13 comments · Fixed by #662
Closed

Don't allow uploading empty files (allowEmptyFiles option) #475

tunnckoCore opened this issue Jun 24, 2018 · 13 comments · Fixed by #662

Comments

@tunnckoCore
Copy link
Member

Source of the #428 and suggested to have some option like allowEmptyFiles: false.

@quantumsheep
Copy link
Collaborator

Is an empty file really a file though?

@tunnckoCore
Copy link
Member Author

Good question. So actually allowEmpty sounds better, really. Also it is a familiar option from other libraries/servers and such.

@xarguments
Copy link
Collaborator

xarguments commented Jun 25, 2018

@quantumsheep, anything that has file structure in file-system table is a file, no matter the size :)
@olstenlarck, in case of allowEmpty it wouldn't be obvious whether its for files, fields, or both. (they seem to be different config names)
So allowEmptyFiles/minFileSize (and allowEmptyFields/minFieldLength ??) seem to be clear in intentions.

@mohemos
Copy link

mohemos commented Sep 26, 2018

This is a serious issue that needs prompt attention because the empty files just mess up the entire folder, I have to run fs.unlink() every time I submit a form that has file with an empty value.

@leonardovillela
Copy link
Contributor

Can i take this issue?

@tunnckoCore
Copy link
Member Author

Yes of course.

@nakedtoast
Copy link

Has this feature request been added yet?

@tunnckoCore
Copy link
Member Author

@nakedtoast unfortunately, seems like we do not have any PRs regarding that.

@shaneosullivan
Copy link

Has there been any movement on this?

@tunnckoCore
Copy link
Member Author

tunnckoCore commented Nov 18, 2020

@shaneosullivan nope, nothing on my end, sorry.

@leonardovillela anything?

@leonardovillela
Copy link
Contributor

Hey, sorry for the late response. I only have time to see the notification now. I will take a look at it this weekend.

@leonardovillela
Copy link
Contributor

@tunnckoCore or @GrosSacASac I want to contribute more to this project, there is another issue you recommend to me to work on?

@GrosSacASac
Copy link
Contributor

#609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants