Skip to content

Should urlencoded support encoding? #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hefangshi opened this issue Aug 7, 2014 · 5 comments
Closed

Should urlencoded support encoding? #294

hefangshi opened this issue Aug 7, 2014 · 5 comments

Comments

@hefangshi
Copy link

We use https://github.com/node-modules/urlencode to create a querystring with gbk encoding, and formidable can't handle the encoding.

Since the multipart encoding works fine, should formidable support the urlencoded encoding setting? I'm willing to create a pr for this.

@felixge
Copy link
Collaborator

felixge commented Aug 7, 2014

I'm not experienced with gbk encoding, but I'd be happy to merge a PR.

@hefangshi
Copy link
Author

not only gbk, and also win1251, ucs2 etc, I'll work on it asap.

@felixge
Copy link
Collaborator

felixge commented Aug 7, 2014

Cool, thanks!

@xarguments
Copy link
Collaborator

@hefangshi, @felixge, was it already done and merged? or maybe PR is pending?
P.S. I'm cleaning up the issues, trying to understand what to do with this issue.

@xarguments xarguments added this to the 1.3.1 milestone Jan 30, 2019
@GrosSacASac GrosSacASac removed this from the 1.3.1 milestone Feb 14, 2021
@GrosSacASac
Copy link
Contributor

In #730 we switched to https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams internally which should handle all the encodings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants