Skip to content

Fix CI error #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hsluoyz opened this issue Aug 25, 2022 · 6 comments · Fixed by #3 or #4
Closed

Fix CI error #2

hsluoyz opened this issue Aug 25, 2022 · 6 comments · Fixed by #3 or #4
Assignees
@hsluoyz
Labels
bug Something isn't working

Comments

@hsluoyz
Copy link
Member

hsluoyz commented Aug 25, 2022

See: https://github.com/node-casbin/mongo-changestream-watcher/actions/runs/2927758423

image
@hsluoyz hsluoyz self-assigned this Aug 25, 2022
@hsluoyz hsluoyz added the bug Something isn't working label Aug 25, 2022
@hsluoyz
Copy link
Member Author

hsluoyz commented Aug 25, 2022

@Sefriol

@Sefriol
Copy link
Contributor

Sefriol commented Aug 25, 2022 •
edited
Loading

MongoDB 6.0 was released just today. I think that's the reason. Dockerfile uses the latest mongodb image. I'll check what are the breaking changes.

EDIT: This has most likely broken the tests for mongoose-adapter as well.

EDIT2: Mongo image does not seem to have mongo command line function, so entry-point.sh scripts fail. docker-library/mongo#558

Sefriol added a commit to Sefriol/mongo-changestream-watcher that referenced this issue Aug 25, 2022
@Sefriol
ci(docker-entrypoint.sh): change mongo commands into mongosh
8083051 
docker-library/mongo#558

fix node-casbin#2
@hsluoyz hsluoyz mentioned this issue Aug 26, 2022
Merged
hsluoyz pushed a commit that referenced this issue Aug 26, 2022
@Sefriol
ci: change mongo commands into mongosh for mongodb 6.0 (#3)
748a81b 
* ci(docker-entrypoint.sh): change mongo commands into mongosh

docker-library/mongo#558

fix #2

* test(watcher.test.ts): add callbackStreamCloseEvent attribute to a test
@hsluoyz hsluoyz reopened this Aug 26, 2022
@hsluoyz
Copy link
Member Author

hsluoyz commented Aug 26, 2022

@Sefriol error: https://github.com/node-casbin/mongo-changestream-watcher/runs/8030455397?check_suite_focus=true

image

@Sefriol
Copy link
Contributor

Sefriol commented Aug 26, 2022

Hmmph. Tests complete before. I guess the semantic-release does not have access to the cluster anymore..

Should the release script run the tests anyway at this point?

@hsluoyz
Copy link
Member Author

hsluoyz commented Aug 26, 2022

@Sefriol refer to other repos: https://github.com/node-casbin

@Sefriol
Copy link
Contributor

Sefriol commented Aug 26, 2022 •
edited
Loading

Other repos do not seem to have husky configured, but it seems that it should be ignored when semantic-release does the release commit.

It seems that I should just disable husky in CI.

EDIT: Yep: https://typicode.github.io/husky/#/?id=disable-husky-in-cidockerprod

Sefriol added a commit to Sefriol/mongo-changestream-watcher that referenced this issue Aug 26, 2022
@Sefriol
ci(main.yml): disable husky in CI
dfe0c3f 
https://typicode.github.io/husky/#/?id=with-env-variables

fix node-casbin#2
@hsluoyz hsluoyz mentioned this issue Aug 26, 2022
Merged
hsluoyz pushed a commit that referenced this issue Aug 26, 2022
@Sefriol
fix: disable husky (#4)
959c89c 
* ci(main.yml): disable husky in CI

https://typicode.github.io/husky/#/?id=with-env-variables

fix #2

* docs(readme.md): fix badge urls
github-actions bot pushed a commit that referenced this issue Aug 26, 2022
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
8a53199 
# 1.0.0 (2022-08-26)

### Bug Fixes

* disable husky ([#4](#4)) ([959c89c](959c89c)), closes [#2](#2)

### Features

* add MongoDB Change Stream Watcher for Node-Casbin ([#1](#1)) ([d5dbdee](d5dbdee))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hsluoyz hsluoyz

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@hsluoyz @Sefriol