precommit allows warnings, npm run lint & PR do not allow warnings

Author: maxyeo

Diff for: .sass-lint-precommit.yml

@@ -0,0 +1,41 @@
+# sass-lint config generated by make-sass-lint-config v0.1.2
+#
+# The following scss-lint Linters are not yet supported by sass-lint:
+# PrivateNamingConvention
+
+files:
+  include: '**/*.s+(a|c)ss'
+options:
+  formatter: stylish
+  merge-default-rules: false
+rules:
+  bem-depth: 1
+  border-zero:
+    - 1
+    - convention: zero
+  brace-style:
+    - 1
+    - allow-single-line: false
+  class-name-format:
+    - 1
+    - convention: ^(?!js-).*
+      convention-explanation: should not be written in the form js-*
+  extends-before-declarations: 0
+  extends-before-mixins: 0
+  function-name-format: 1
+  id-name-format:
+    - 1
+    - convention: hyphenatedbem
+  leading-zero: 0
+  mixin-name-format: 1
+  mixins-before-declarations: 0
+  no-extends: 1
+  no-qualifying-elements: 0
+  placeholder-name-format:
+    - 1
+    - convention: hyphenatedbem
+  property-sort-order: 0
+  quotes:
+    - 1
+    - style: double
+  variable-name-format: 1

Diff for: .sass-lint.yml

@@ -9,33 +9,33 @@ options:
   formatter: stylish
   merge-default-rules: false
 rules:
-  bem-depth: 1
+  bem-depth: 2
   border-zero:
-    - 1
+    - 2
     - convention: zero
   brace-style:
-    - 1
+    - 2
     - allow-single-line: false
   class-name-format:
-    - 1
+    - 2
     - convention: ^(?!js-).*
       convention-explanation: should not be written in the form js-*
   extends-before-declarations: 0
   extends-before-mixins: 0
   function-name-format: 1
   id-name-format:
-    - 1
+    - 2
     - convention: hyphenatedbem
   leading-zero: 0
-  mixin-name-format: 1
+  mixin-name-format: 2
   mixins-before-declarations: 0
-  no-extends: 1
+  no-extends: 2
   no-qualifying-elements: 0
   placeholder-name-format:
-    - 1
+    - 2
     - convention: hyphenatedbem
   property-sort-order: 0
   quotes:
-    - 1
+    - 2
     - style: double
-  variable-name-format: 1
+  variable-name-format: 2

Diff for: package.json

@@ -81,7 +81,7 @@
     "lint-staged": "lint-staged",
     "lint-fix": "./node_modules/.bin/eslint --fix static/js/redux/* static/js/redux/alerts/* static/js/redux/actions/* static/js/redux/constants/* static/js/redux/reducers/* static/js/redux/ui/containers/* static/js/redux/ui/alerts/*",
     "lint": "./node_modules/.bin/eslint static/js/redux/*/*; ./node_modules/.bin/sass-lint -c .sass-lint.yml 'static/css/timetable/*.scss, static/css/timetable/**/*.scss' -v -q",
-    "lint-scss-staged": "./node_modules/.bin/sass-lint -c .sass-lint.yml -v -q"
+    "lint-scss-staged": "./node_modules/.bin/sass-lint -c .sass-lint-precommit.yml -v -q"
   },
   "repository": {
     "type": "git",