From 671fa21b684490216620c1958233419d2946839a Mon Sep 17 00:00:00 2001 From: njank Date: Fri, 4 Oct 2024 09:20:13 +0700 Subject: [PATCH] move unit test to the correct class, add positive test case #366 --- .../yaml/failing/SimpleGeneration215Test.java | 20 -------- .../yaml/failing/SimpleGeneration366Test.java | 50 +++++++++++++++++++ 2 files changed, 50 insertions(+), 20 deletions(-) create mode 100644 yaml/src/test/java/com/fasterxml/jackson/dataformat/yaml/failing/SimpleGeneration366Test.java diff --git a/yaml/src/test/java/com/fasterxml/jackson/dataformat/yaml/failing/SimpleGeneration215Test.java b/yaml/src/test/java/com/fasterxml/jackson/dataformat/yaml/failing/SimpleGeneration215Test.java index 603582a27..114612b0f 100644 --- a/yaml/src/test/java/com/fasterxml/jackson/dataformat/yaml/failing/SimpleGeneration215Test.java +++ b/yaml/src/test/java/com/fasterxml/jackson/dataformat/yaml/failing/SimpleGeneration215Test.java @@ -1,8 +1,6 @@ package com.fasterxml.jackson.dataformat.yaml.failing; import java.util.Collections; -import java.util.HashMap; -import java.util.Map; import com.fasterxml.jackson.dataformat.yaml.ModuleTestBase; import com.fasterxml.jackson.dataformat.yaml.YAMLFactory; @@ -34,22 +32,4 @@ public void testStartMarkerViaMapper() throws Exception .trim(); assertEquals("key: \"value\"", output); } - - public void testLiteralBlockStyleMultilineWithTrailingSpace() throws Exception - { - YAMLFactory f = new YAMLFactory(); - // verify default settings - assertFalse(f.isEnabled(YAMLGenerator.Feature.LITERAL_BLOCK_STYLE)); - - YAMLMapper mapper = YAMLMapper.builder() - .configure(YAMLGenerator.Feature.LITERAL_BLOCK_STYLE, true) - .build(); - - Map content = new HashMap(); - content.put("text", "Hello\nWorld "); - String yaml = mapper.writeValueAsString(content).trim(); - - assertEquals("---\n" + - "text: |-\n Hello\n World ", yaml); - } } diff --git a/yaml/src/test/java/com/fasterxml/jackson/dataformat/yaml/failing/SimpleGeneration366Test.java b/yaml/src/test/java/com/fasterxml/jackson/dataformat/yaml/failing/SimpleGeneration366Test.java new file mode 100644 index 000000000..96668e7c9 --- /dev/null +++ b/yaml/src/test/java/com/fasterxml/jackson/dataformat/yaml/failing/SimpleGeneration366Test.java @@ -0,0 +1,50 @@ +package com.fasterxml.jackson.dataformat.yaml.failing; + +import com.fasterxml.jackson.dataformat.yaml.ModuleTestBase; +import com.fasterxml.jackson.dataformat.yaml.YAMLFactory; +import com.fasterxml.jackson.dataformat.yaml.YAMLGenerator; +import com.fasterxml.jackson.dataformat.yaml.YAMLMapper; + +import java.util.HashMap; +import java.util.Map; + +public class SimpleGeneration366Test extends ModuleTestBase +{ + // [dataformats-text#366]: multiline literal block with trailing spaces does not work + public void testLiteralBlockStyleMultilineWithTrailingSpace() throws Exception + { + YAMLFactory f = new YAMLFactory(); + // verify default settings + assertFalse(f.isEnabled(YAMLGenerator.Feature.LITERAL_BLOCK_STYLE)); + + YAMLMapper mapper = YAMLMapper.builder() + .configure(YAMLGenerator.Feature.LITERAL_BLOCK_STYLE, true) + .build(); + + Map content = new HashMap(); + content.put("text", "Hello\nWorld "); + String yaml = mapper.writeValueAsString(content).trim(); + + assertEquals("---\n" + + "text: |-\n Hello\n World ", yaml); + } + + // [dataformats-text#366]: multiline literal block without trailing spaces actually works + public void testLiteralBlockStyleMultiline() throws Exception + { + YAMLFactory f = new YAMLFactory(); + // verify default settings + assertFalse(f.isEnabled(YAMLGenerator.Feature.LITERAL_BLOCK_STYLE)); + + YAMLMapper mapper = YAMLMapper.builder() + .configure(YAMLGenerator.Feature.LITERAL_BLOCK_STYLE, true) + .build(); + + Map content = new HashMap(); + content.put("text", "Hello\nWorld"); + String yaml = mapper.writeValueAsString(content).trim(); + + assertEquals("---\n" + + "text: |-\n Hello\n World", yaml); + } +}