-
-
Notifications
You must be signed in to change notification settings - Fork 285
vicinae: add support for official home-manager options #2068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
b6cf684 to
34ea4a0
Compare
0xda157
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a testbed for the home-manager options should be added
|
Applied all suggested improvements, awaiting a review :) |
|
I've been looking at other examples to better understand how stylix works. And looks like there is no need to check for presence of So maybe, a final implementation for eachConfig =
config:
let
finalConfig = {
vicinae = config;
};
in
{
services = lib.optionalAttrs (options.services ? vicinae) finalConfig;
programs = finalConfig;
};What do you think? |
|
this should be merged after nix-community/home-manager#8313 is merged (if it isn't rejected). |
Description
Adds support for official home-manager options for vicinae (configured via
programs.vicinaeinstead ofservices.vicinae).Official options for vicinae in home-manager were added in nix-community/home-manager#8093.
As stated by the author, these options should work the same way:
This is not a breaking change, users of the options that come from vicinae flake don't lose anything.
I'm welcome to hear any feedback.
Thank you for this amazing tool!