-
-
Notifications
You must be signed in to change notification settings - Fork 286
i3: add testbed #1767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
i3: add testbed #1767
Conversation
trueNAHO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not entirely sure why autologin is working
Do you mean autologin "is working" or "is not working"? Except for that, this PR LGTM.
AFAIK, we are enabling autologin by default:
stylix/stylix/testbed/modules/application.nix
Lines 94 to 98 in fc24382
config = lib.mkIf (config.stylix.testbed.ui != null) { services.displayManager.autoLogin = { enable = true; user = user.username; }; stylix/stylix/testbed/modules/common.nix
Line 10 in fc24382
services.getty.autologinUser = user.username;
"not working," some sort of display manager got enabled without explicitly enabling it. I went looking for stuff enabling i3 enables and didn't have any luck. |
@jezcope, @nilp0inter, @qaristote, @zackattackz, do you happen to know what might be triggering the
display manager despite our existing autologin logic:
You can replicate this in a temporary VM by running: nix run github:awwpotato/stylix/i3-testbed#testbed:i3:dark |
|
Is there any reason that this isn't being added as a graphical environment? |
trueNAHO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason that this isn't being added as a graphical environment?
Probably just did not think about this since this PR was opened only 10 days after the long-pending commit 8c854fe ("stylix: allow choosing testbed desktop (#1222)"). Would be nice to also abstract the i3 window manager as a graphical environment.
Regarding the autologin issue, I am fine with merging this testbed without resolving this issue, and adding it to #1731.

not entirely sure why autologin is not working
Things done
Notify maintainers