Skip to content

[nixpkgs] default to constructing our own instance #2839

@MattSturgeon

Description

@MattSturgeon

#2738 introduced nixpkgs.useGlobalPackages which currently defaults to true, however it should really default to false.

Motivation

  • Using a nixpkgs from our flake.lock will reduce mismatched pkgs version errors
  • Using an internally constructed nixpkgs instance allows users to configure config, overlays, etc as nixvim module options

Issues

This is a breaking change, especially if users have configured config, overlays, etc outside of Nixvim and expect that config to be inherited by nixvim.

Deprecation

I don't know an obnoxious way to warn users the default value will/has change.

Currently the plan is documented as a literalMD default-text.

Pre-migration, we could warn if users have not explicitly defined the option (i.e. highestPrio == 1500). This would be a very visible and obnoxious warning, and would require users to explicitly define an option they probably don't care about.

Post-migration, we could warn if users have explicitly overridden the default to be false. This would notify users that have migrated early they no longer need to do so explicitly, however it is a bit heavy handed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    tech debtRelated to technical debt and/or refactoring

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions