Skip to content

Commit e494b56

Browse files
floklikolloch
authored andcommitted
rename TODO to NOTE
There's nothing immediately actionable for raito here, let's make this a generic NOTE, so people stumbling into this know to open a bug report.
1 parent 7eb26c5 commit e494b56

File tree

5 files changed

+15
-10
lines changed

5 files changed

+15
-10
lines changed

crate2nix/Cargo.nix

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2894,8 +2894,9 @@ rec {
28942894
# because we compiled those test binaries in the former and not the latter.
28952895
# So all paths will expect source tree to be there and not in the build top directly.
28962896
# For example: $NIX_BUILD_TOP := /build in general, if you ask yourself.
2897-
# TODO(raitobezarius): I believe there could be more edge cases if `crate.sourceRoot`
2898-
# do exist but it's very hard to reason about them, so let's wait until the first bug report.
2897+
# NOTE: There could be edge cases if `crate.sourceRoot` does exist but
2898+
# it's very hard to reason about them.
2899+
# Open a bug if you run into this!
28992900
mkdir -p source/
29002901
cd source/
29012902

crate2nix/templates/nix/crate2nix/default.nix

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,9 @@ rec {
140140
# because we compiled those test binaries in the former and not the latter.
141141
# So all paths will expect source tree to be there and not in the build top directly.
142142
# For example: $NIX_BUILD_TOP := /build in general, if you ask yourself.
143-
# TODO(raitobezarius): I believe there could be more edge cases if `crate.sourceRoot`
144-
# do exist but it's very hard to reason about them, so let's wait until the first bug report.
143+
# NOTE: There could be edge cases if `crate.sourceRoot` does exist but
144+
# it's very hard to reason about them.
145+
# Open a bug if you run into this!
145146
mkdir -p source/
146147
cd source/
147148

sample_projects/bin_with_git_submodule_dep/Cargo.nix

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1488,8 +1488,9 @@ rec {
14881488
# because we compiled those test binaries in the former and not the latter.
14891489
# So all paths will expect source tree to be there and not in the build top directly.
14901490
# For example: $NIX_BUILD_TOP := /build in general, if you ask yourself.
1491-
# TODO(raitobezarius): I believe there could be more edge cases if `crate.sourceRoot`
1492-
# do exist but it's very hard to reason about them, so let's wait until the first bug report.
1491+
# NOTE: There could be edge cases if `crate.sourceRoot` does exist but
1492+
# it's very hard to reason about them.
1493+
# Open a bug if you run into this!
14931494
mkdir -p source/
14941495
cd source/
14951496

sample_projects/codegen/Cargo.nix

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -663,8 +663,9 @@ rec {
663663
# because we compiled those test binaries in the former and not the latter.
664664
# So all paths will expect source tree to be there and not in the build top directly.
665665
# For example: $NIX_BUILD_TOP := /build in general, if you ask yourself.
666-
# TODO(raitobezarius): I believe there could be more edge cases if `crate.sourceRoot`
667-
# do exist but it's very hard to reason about them, so let's wait until the first bug report.
666+
# NOTE: There could be edge cases if `crate.sourceRoot` does exist but
667+
# it's very hard to reason about them.
668+
# Open a bug if you run into this!
668669
mkdir -p source/
669670
cd source/
670671

sample_projects/sub_dir_crates/Cargo.nix

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,8 +272,9 @@ rec {
272272
# because we compiled those test binaries in the former and not the latter.
273273
# So all paths will expect source tree to be there and not in the build top directly.
274274
# For example: $NIX_BUILD_TOP := /build in general, if you ask yourself.
275-
# TODO(raitobezarius): I believe there could be more edge cases if `crate.sourceRoot`
276-
# do exist but it's very hard to reason about them, so let's wait until the first bug report.
275+
# NOTE: There could be edge cases if `crate.sourceRoot` does exist but
276+
# it's very hard to reason about them.
277+
# Open a bug if you run into this!
277278
mkdir -p source/
278279
cd source/
279280

0 commit comments

Comments
 (0)