Merge branch 'aa-change-implementation-requiredMeasures' of https://github.com/adnasa/react-perf-devtool into adnasa-aa-change-implementation-requiredMeasures

Author: nitin42

__tests__/logMeasures.js

@@ -49,13 +49,13 @@ function logToConsole({ port, components }, measures) {
   if (!components) {
     logMeasures(measures)
   } else if (typeof components !== undefined && Array.isArray(components)) {
-    var stats = getRequiredMeasures(components, measures)
+    var stats = getMeasuresByComponentName(components, measures)
 
     logMeasures(stats)
   }
 }
 
-function getRequiredMeasures(components, measures) {
+function getMeasuresByComponentName(components, measures) {
   var requiredMeasures = []
 
   if (!Array.isArray(components)) {

__tests__/registerObserver.test.js

@@ -1,4 +1,7 @@
-var { registerObserver } = require('../src/npm/hook')
+var {
+  registerObserver,
+  getMeasuresByComponentName
+} = require('../src/npm/hook')
 
 describe('Register Observer', () => {
   describe('The register observer function shouldnt crash', () => {
@@ -32,3 +35,43 @@ describe('Register Observer', () => {
     })
   })
 })
+
+describe('utils', () => {
+  let componentNames
+  let measures
+  let requiredMeasures
+  describe('getMeasuresByComponentName', () => {
+    describe('with matching `componentNames`', () => {
+      beforeEach(() => {
+        componentNames = ['foo']
+        measures = [
+          {
+            componentName: 'foo'
+          }
+        ]
+        requiredMeasures = getMeasuresByComponentName(componentNames, measures)
+      })
+      it('should return a list of required measure', () => {
+        expect(requiredMeasures).toEqual([
+          {
+            componentName: 'foo'
+          }
+        ])
+      })
+    })
+    describe('without matching `componentNames`', () => {
+      beforeEach(() => {
+        componentNames = ['foo']
+        measures = [
+          {
+            componentName: 'bar'
+          }
+        ]
+        requiredMeasures = getMeasuresByComponentName(componentNames, measures)
+      })
+      it('should return a list of empty measure', () => {
+        expect(requiredMeasures).toEqual([])
+      })
+    })
+  })
+})

src/npm/hook.js

@@ -71,9 +71,7 @@ const logToConsole = ({ port, components }, measures) => {
   if (!components) {
     logMeasures(port, measures)
   } else if (typeof components !== undefined && Array.isArray(components)) {
-    const requiredMeasures = getRequiredMeasures(components, measures)
-
-    logMeasures(port, requiredMeasures)
+    logMeasures(port, getMeasuresByComponentName(components, measures))
   }
 }
 
@@ -131,20 +129,7 @@ const send = (data, port) => {
   )
 }
 
-const getRequiredMeasures = (components, measures) => {
-  let requiredMeasures = []
-
-  if (!Array.isArray(components)) {
-    components = [components]
-  }
-
-  measures.forEach(measure => {
-    if (components.includes(measure.componentName)) {
-      requiredMeasures.push(measure)
-    }
-  })
-
-  return requiredMeasures
-}
+const getMeasuresByComponentName = (componentNames, measures) =>
+  measures.filter(measure => componentNames.includes(measure.componentName))
 
-export { registerObserver }
+export { registerObserver, getMeasuresByComponentName }